Subzero: Dump register numbers as signed quantities.

Undo an overly aggression application of unsigned to register numbers in 8aa39661 (https://codereview.chromium.org/1676123002). Now, instead of -verbose=regalloc output like: ++++++ Unhandled: R=jpp@chromium.org, kschimpf@google.com, 4294967295 V=%__4 Range=[2:7), 4294967295 V=%__5 Range=[7:8), 4294967295 V=%__6 Range=[9:11), -1 V=%__4 Range=[2:7), -1 V=%__5 Range=[7:8), -1 V=%__6 Range=[9:11) we have the originally intended: ++++++ Unhandled: BUG= none Review URL: https://codereview.chromium.org/1868543002 .

Subzero: Dump register numbers as signed quantities.
11756b51 · Jim Stichnoth · 2b000fd8 · 11756b51
Commit 11756b51 authored Apr 06, 2016 by Jim Stichnoth
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 4 deletions

IceRegAlloc.cpp src/IceRegAlloc.cpp +9 -4

No files found.
--- a/src/IceRegAlloc.cpp
+++ b/src/IceRegAlloc.cpp
@@ -23,6 +23,8 @@
 #include "IceOperand.h"
 #include "IceTargetLowering.h"
+#include "llvm/Support/Format.h"
 namespace Ice {
 namespace {
@@ -70,10 +72,13 @@ void dumpLiveRange(const Variable *Var, const Cfg *Func) {
  if (!BuildDefs::dump())
    return;
  Ostream &Str = Func->getContext()->getStrDump();
-  char buf[30];
+  Str << "R=";
-  snprintf(buf, llvm::array_lengthof(buf), "%2u",
+  if (Var->hasRegTmp()) {
-           unsigned(Var->getRegNumTmp()));
+    Str << llvm::format("%2d", Var->getRegNumTmp());
-  Str << "R=" << buf << "  V=";
+  } else {
+    Str << "NA";
+  }
+  Str << "  V=";
  Var->dump(Func);
  Str << "  Range=" << Var->getLiveRange();
 }