Skip to content

S
swiftshader
Commit 131a1ba8 by Alexis Hetu Committed by Alexis Hétu
Options

libVulkan references and deferences structures uselessly

In libVulkan.cpp, many structures are received as pointers, which are dereferenced, only to be references on the next line. We can just take the pointers as is. Bug: b/144943261 Change-Id: I60585ab5e953dc9baf1f6951a3762c890ab95641 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38530 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: 's avatarAlexis Hétu <sugoi@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
parent 698235ce
Showing with 53 additions and 48 deletions
src/Vulkan/VkDevice.cpp
...@@ -232,6 +232,12 @@ void Device::updateDescriptorSets(uint32_t descriptorWriteCount, const VkWriteDe ...@@ -232,6 +232,12 @@ void Device::updateDescriptorSets(uint32_t descriptorWriteCount, const VkWriteDe
} }
} }
void Device::getRequirements(VkMemoryDedicatedRequirements* requirements) const
{
requirements->prefersDedicatedAllocation = VK_FALSE;
requirements->requiresDedicatedAllocation = VK_FALSE;
}
Device::SamplingRoutineCache* Device::getSamplingRoutineCache() const Device::SamplingRoutineCache* Device::getSamplingRoutineCache() const
{ {
return samplingRoutineCache.get(); return samplingRoutineCache.get();
......
src/Vulkan/VkDevice.hpp
...@@ -56,6 +56,7 @@ public: ...@@ -56,6 +56,7 @@ public:
PhysicalDevice *getPhysicalDevice() const { return physicalDevice; } PhysicalDevice *getPhysicalDevice() const { return physicalDevice; }
void updateDescriptorSets(uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites, void updateDescriptorSets(uint32_t descriptorWriteCount, const VkWriteDescriptorSet* pDescriptorWrites,
uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies); uint32_t descriptorCopyCount, const VkCopyDescriptorSet* pDescriptorCopies);
void getRequirements(VkMemoryDedicatedRequirements* requirements) const;
const VkPhysicalDeviceFeatures &getEnabledFeatures() const { return enabledFeatures; } const VkPhysicalDeviceFeatures &getEnabledFeatures() const { return enabledFeatures; }
sw::Blitter* getBlitter() const { return blitter.get(); } sw::Blitter* getBlitter() const { return blitter.get(); }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment