Add check for vtable in memset template

This change makes sure the memset template is not used with classes that contain virtual members. Bug: b/152253831 Change-Id: I07d4777f33a9bd55c8f99d8b50a80c13df5d5805 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/49648 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Jari Komppa <jari@siru.fi>

Add check for vtable in memset template
1459d852 · Jari Komppa · Jari Komppa · e6c94972 · 1459d852
Commit 1459d852 authored Oct 28, 2020 by Jari Komppa Committed by Jari Komppa Oct 30, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

Memset.hpp src/Device/Memset.hpp +1 -0

No files found.
--- a/src/Device/Memset.hpp
+++ b/src/Device/Memset.hpp
@@ -38,6 +38,7 @@ struct Memset
 	Memset(T *object, int val)
 	{
 		static_assert(std::is_base_of<Memset<T>, T>::value, "Memset<T> must only clear the memory of a type of which it is a base class");
+		static_assert(!std::is_polymorphic<T>::value, "Memset<T> must not be used with classes that have virtual functions");
 		::memset(object, 0, sizeof(T));
 	}