Device: Use std::unique_ptr instead of raw pointers

src/Device/PixelProcessor.cpp

@@ -50,16 +50,9 @@ bool PixelProcessor::State::operator==(const State &state) const
 
 PixelProcessor::PixelProcessor()
 {
-	routineCache = nullptr;
 	setRoutineCacheSize(1024);
 }
 
-PixelProcessor::~PixelProcessor()
-{
-	delete routineCache;
-	routineCache = nullptr;
-}
-
 void PixelProcessor::setBlendConstant(const float4 &blendConstant)
 {
 	// TODO(b/140935644): Check if clamp is required
@@ -86,8 +79,7 @@ void PixelProcessor::setBlendConstant(const float4 &blendConstant)
 
 void PixelProcessor::setRoutineCacheSize(int cacheSize)
 {
-	delete routineCache;
-	routineCache = new RoutineCacheType(clamp(cacheSize, 1, 65536));
+	routineCache = std::make_unique<RoutineCacheType>(clamp(cacheSize, 1, 65536));
 }
 
 const PixelProcessor::State PixelProcessor::update(const Context *context) const

src/Device/PixelProcessor.hpp

@@ -19,6 +19,8 @@
 #include "Memset.hpp"
 #include "RoutineCache.hpp"
 
+#include <memory>
+
 namespace sw {
 
 class PixelShader;
@@ -146,8 +148,6 @@ public:
 
 	PixelProcessor();
 
-	virtual ~PixelProcessor();
-
 	void setBlendConstant(const float4 &blendConstant);
 
 	const State update(const Context *context) const;
@@ -160,7 +160,7 @@ public:
 
 private:
 	using RoutineCacheType = RoutineCache<State, RasterizerFunction::CFunctionType>;
-	RoutineCacheType *routineCache;
+	std::unique_ptr<RoutineCacheType> routineCache;
 };
 
 }  // namespace sw

src/Device/SetupProcessor.cpp

@@ -52,16 +52,9 @@ bool SetupProcessor::State::operator==(const State &state) const
 
 SetupProcessor::SetupProcessor()
 {
-	routineCache = nullptr;
 	setRoutineCacheSize(1024);
 }
 
-SetupProcessor::~SetupProcessor()
-{
-	delete routineCache;
-	routineCache = nullptr;
-}
-
 SetupProcessor::State SetupProcessor::update(const sw::Context *context) const
 {
 	State state;
@@ -117,8 +110,7 @@ SetupProcessor::RoutineType SetupProcessor::routine(const State &state)
 
 void SetupProcessor::setRoutineCacheSize(int cacheSize)
 {
-	delete routineCache;
-	routineCache = new RoutineCacheType(clamp(cacheSize, 1, 65536));
+	routineCache = std::make_unique<RoutineCacheType>(clamp(cacheSize, 1, 65536));
 }
 
 }  // namespace sw

src/Device/SetupProcessor.hpp

@@ -21,6 +21,8 @@
 #include "System/Types.hpp"
 #include <Pipeline/SpirvShader.hpp>
 
+#include <memory>
+
 namespace sw {
 
 struct Primitive;
@@ -71,8 +73,6 @@ public:
 
 	SetupProcessor();
 
-	~SetupProcessor();
-
 	State update(const sw::Context *context) const;
 	RoutineType routine(const State &state);
 
@@ -80,7 +80,7 @@ public:
 
 private:
 	using RoutineCacheType = RoutineCache<State, SetupFunction::CFunctionType>;
-	RoutineCacheType *routineCache;
+	std::unique_ptr<RoutineCacheType> routineCache;
 };
 
 }  // namespace sw

src/Device/VertexProcessor.cpp

@@ -57,20 +57,12 @@ bool VertexProcessor::State::operator==(const State &state) const
 
 VertexProcessor::VertexProcessor()
 {
-	routineCache = nullptr;
 	setRoutineCacheSize(1024);
 }
 
-VertexProcessor::~VertexProcessor()
-{
-	delete routineCache;
-	routineCache = nullptr;
-}
-
 void VertexProcessor::setRoutineCacheSize(int cacheSize)
 {
-	delete routineCache;
-	routineCache = new RoutineCacheType(clamp(cacheSize, 1, 65536));
+	routineCache = std::make_unique<RoutineCacheType>(clamp(cacheSize, 1, 65536));
 }
 
 const VertexProcessor::State VertexProcessor::update(const sw::Context *context)

src/Device/VertexProcessor.hpp

@@ -21,6 +21,8 @@
 #include "Vertex.hpp"
 #include "Pipeline/SpirvShader.hpp"
 
+#include <memory>
+
 namespace sw {
 
 struct DrawData;
@@ -92,8 +94,6 @@ public:
 
 	VertexProcessor();
 
-	virtual ~VertexProcessor();
-
 	const State update(const sw::Context *context);
 	RoutineType routine(const State &state, vk::PipelineLayout const *pipelineLayout,
 	                    SpirvShader const *vertexShader, const vk::DescriptorSet::Bindings &descriptorSets);
@@ -102,7 +102,7 @@ public:
 
 private:
 	using RoutineCacheType = RoutineCache<State, VertexRoutineFunction::CFunctionType>;
-	RoutineCacheType *routineCache;
+	std::unique_ptr<RoutineCacheType> routineCache;
 };
 
 }  // namespace sw