Flush the instruction cache after loading JIT compiled code.

x86 does not strictly require this because it performs snooping to ensure consistency, but it is essential on ARM and some other architectures. Bug b/37478805 Change-Id: I9fad94571ec65b67132ba40c3e1814c63d6af468 Reviewed-on: https://swiftshader-review.googlesource.com/9429Reviewed-by: Nicolas Capens <capn@google.com> Tested-by: Nicolas Capens <capn@google.com>

Flush the instruction cache after loading JIT compiled code.
1cc44388 · Nicolas Capens · 35e0ba77 · 1cc44388
Commit 1cc44388 authored Apr 25, 2017 by Nicolas Capens
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 2 deletions

SubzeroReactor.cpp src/Reactor/SubzeroReactor.cpp +10 -2

No files found.
--- a/src/Reactor/SubzeroReactor.cpp
+++ b/src/Reactor/SubzeroReactor.cpp
@@ -289,7 +289,7 @@ namespace sw
 		return symbolValue;
 	}

-	void *loadImage(uint8_t *const elfImage)
+	void *loadImage(uint8_t *const elfImage, size_t &codeSize)
 	{
 		ElfHeader *elfHeader = (ElfHeader*)elfImage;

@@ -312,6 +312,7 @@ namespace sw
 				if(sectionHeader[i].sh_flags & SHF_EXECINSTR)
 				{
 					entry = elfImage + sectionHeader[i].sh_offset;
+					codeSize = sectionHeader[i].sh_size;
 				}
 			}
 			else if(sectionHeader[i].sh_type == SHT_REL)
@@ -429,7 +430,14 @@ namespace sw

 				position = std::numeric_limits<std::size_t>::max();   // Can't stream more data after this

-				entry = loadImage(&buffer[0]);
+				size_t codeSize = 0;
+				entry = loadImage(&buffer[0], codeSize);
+
+				#if defined(_WIN32)
+					FlushInstructionCache(GetCurrentProcess(), NULL, 0);
+				#else
+					__builtin___clear_cache((char*)entry, (char*)entry + codeSize);
+				#endif
 			}

 			return entry;