SpirvShader: Fully initialize variables in emitSamplerFunction()

Let's just initialize these to zero, and let the optimizer remove redundant assignments. Bug: b/136149446 Change-Id: Ia776bae4433f78f5a66b16f275e728a70dd4e18d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/33468Tested-by: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com>

SpirvShader: Fully initialize variables in emitSamplerFunction()
1d6301dc · Ben Clayton · 0b00b956 · 1d6301dc
Commit 1d6301dc authored Jun 27, 2019 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 6 deletions

SpirvShaderSampling.cpp src/Pipeline/SpirvShaderSampling.cpp +6 -6

No files found.
--- a/src/Pipeline/SpirvShaderSampling.cpp
+++ b/src/Pipeline/SpirvShaderSampling.cpp
@@ -125,12 +125,12 @@ SpirvShader::ImageSampler *SpirvShader::emitSamplerFunction(ImageInstruction ins
 		Pointer<SIMD::Float> out = function.Arg<3>();
 		Pointer<Byte> constants = function.Arg<4>();
-		SIMD::Float uvw[4];
+		SIMD::Float uvw[4] = {0, 0, 0, 0};
-		SIMD::Float q;
+		SIMD::Float q = 0;
-		SIMD::Float lodOrBias;  // Explicit level-of-detail, or bias added to the implicit level-of-detail (depending on samplerMethod).
+		SIMD::Float lodOrBias = 0;  // Explicit level-of-detail, or bias added to the implicit level-of-detail (depending on samplerMethod).
-		Vector4f dsx;
+		Vector4f dsx = {0, 0, 0, 0};
-		Vector4f dsy;
+		Vector4f dsy = {0, 0, 0, 0};
-		Vector4f offset;
+		Vector4f offset = {0, 0, 0, 0};
 		SamplerFunction samplerFunction = instruction.getSamplerFunction();
 		uint32_t i = 0;