Commit 214ec337 by Nico Weber

Fix Wrange-loop-analysis warnings in swiftshader.

Bug: chromium:1039697 Change-Id: I5af47f44696a0eb1da7516ea57f3ae766651cae3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41548 Presubmit-Ready: Nico Weber <thakis@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent 84785608
...@@ -1454,7 +1454,7 @@ namespace es2 ...@@ -1454,7 +1454,7 @@ namespace es2
} }
bool found = false; bool found = false;
for(const glsl::Varying varying : vertexShader->varyings) for(const glsl::Varying& varying : vertexShader->varyings)
{ {
if(tfVaryingName == varying.name) if(tfVaryingName == varying.name)
{ {
......
...@@ -1396,7 +1396,7 @@ void HoistSpillHelper::runHoistSpills( ...@@ -1396,7 +1396,7 @@ void HoistSpillHelper::runHoistSpills(
} }
// For spills in SpillsToKeep with LiveReg set (i.e., not original spill), // For spills in SpillsToKeep with LiveReg set (i.e., not original spill),
// save them to SpillsToIns. // save them to SpillsToIns.
for (const auto Ent : SpillsToKeep) { for (const auto& Ent : SpillsToKeep) {
if (Ent.second) if (Ent.second)
SpillsToIns[Ent.first->getBlock()] = Ent.second; SpillsToIns[Ent.first->getBlock()] = Ent.second;
} }
...@@ -1470,7 +1470,7 @@ void HoistSpillHelper::hoistAllSpills() { ...@@ -1470,7 +1470,7 @@ void HoistSpillHelper::hoistAllSpills() {
StackIntvl.getValNumInfo(0)); StackIntvl.getValNumInfo(0));
// Insert hoisted spills. // Insert hoisted spills.
for (auto const Insert : SpillsToIns) { for (auto const& Insert : SpillsToIns) {
MachineBasicBlock *BB = Insert.first; MachineBasicBlock *BB = Insert.first;
unsigned LiveReg = Insert.second; unsigned LiveReg = Insert.second;
MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB); MachineBasicBlock::iterator MI = IPA.getLastInsertPointIter(OrigLI, *BB);
......
...@@ -929,7 +929,7 @@ AttributeList::get(LLVMContext &C, ...@@ -929,7 +929,7 @@ AttributeList::get(LLVMContext &C,
MaxIndex = Attrs[Attrs.size() - 2].first; MaxIndex = Attrs[Attrs.size() - 2].first;
SmallVector<AttributeSet, 4> AttrVec(attrIdxToArrayIdx(MaxIndex) + 1); SmallVector<AttributeSet, 4> AttrVec(attrIdxToArrayIdx(MaxIndex) + 1);
for (const auto Pair : Attrs) for (const auto& Pair : Attrs)
AttrVec[attrIdxToArrayIdx(Pair.first)] = Pair.second; AttrVec[attrIdxToArrayIdx(Pair.first)] = Pair.second;
return getImpl(C, AttrVec); return getImpl(C, AttrVec);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment