Fix always performing early depth test when requested

The SPIR-V 'EarlyFragmentTests' execution mode requires performing additional per-fragment tests prior to fragment shader execution, even if depth values computed by the shader would otherwise affect them: https://www.khronos.org/registry/vulkan/specs/1.1/html/vkspec.html#shaders-fragment-earlytest Bug: b/140302392 Change-Id: If5d836a35ee9cfc758243b34fad1222d1b0f1085 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/51888 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>

Fix always performing early depth test when requested
22be66d4 · Nicolas Capens · Nicolas Capens · 89fd1480 · 22be66d4
Commit 22be66d4 authored Jan 19, 2021 by Nicolas Capens Committed by Nicolas Capens Jan 20, 2021
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

PixelRoutine.cpp src/Pipeline/PixelRoutine.cpp +1 -2

No files found.
--- a/src/Pipeline/PixelRoutine.cpp
+++ b/src/Pipeline/PixelRoutine.cpp
@@ -57,8 +57,7 @@ PixelRoutine::~PixelRoutine()
 void PixelRoutine::quad(Pointer<Byte> cBuffer[RENDERTARGETS], Pointer<Byte> &zBuffer, Pointer<Byte> &sBuffer, Int cMask[4], Int &x, Int &y)
 {
-	// TODO: consider shader which modifies sample mask in general
+	const bool earlyDepthTest = !spirvShader || spirvShader->getModes().EarlyFragmentTests;
-	const bool earlyDepthTest = !spirvShader || (spirvShader->getModes().EarlyFragmentTests && !spirvShader->getModes().DepthReplacing && !state.alphaToCoverage);
 	Int zMask[4];  // Depth mask
 	Int sMask[4];  // Stencil mask