Skip to content

S
swiftshader
Commit 2fbd57b6 by Nicolas Capens Committed by Nicolas Capens
Options

Regres: Test changes from external contributors if reviewed by Googler

Previously only changes authored by Googlers would be tested, leaving external contributions untested until the next 'daily' run. This change enables testing of external contributions when a Googler added a Code-Review+1, Code-Review+2, or Presubmit-Ready+1 vote. Change-Id: I2f5c327848ad507d75967c9fd7f16085d0729a1a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45508Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent 11dd7183
Showing with 5 additions and 2 deletions
tests/regres/cmd/regres/main.go
...@@ -989,8 +989,11 @@ func (c *changeInfo) update(client *gerrit.Client) error { ...@@ -989,8 +989,11 @@ func (c *changeInfo) update(client *gerrit.Client) error {
c.priority++ c.priority++
} }
// Is the change from a Googler? // Is the change from a Googler or reviewed by a Googler?
canTest := strings.HasSuffix(current.Commit.Committer.Email, "@google.com") canTest := strings.HasSuffix(current.Commit.Committer.Email, "@google.com") ||
strings.HasSuffix(change.Labels["Code-Review"].Approved.Email, "@google.com") ||
strings.HasSuffix(change.Labels["Code-Review"].Recommended.Email, "@google.com") ||
strings.HasSuffix(change.Labels["Presubmit-Ready"].Approved.Email, "@google.com")
// Has the latest patchset already been tested? // Has the latest patchset already been tested?
if canTest { if canTest {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment