Skip to content

S
swiftshader
Commit 314aa755 by Nicolas Capens Committed by Nicolas Capens
Options

Remove vkGetInstanceProcAddr from exported symbols on Android

Android only allows access to the ICD's functions, through the Vulkan Loader interface functions. This was causing direct access to vkGetPhysicalDeviceSurfaceFormatsKHR, while Android's libvulkan must override it to provide an implementation based on AHardwareBuffer, which affects things like wide-gamut support. Bug: b/182576189 Bug: b/148822450 Change-Id: I64fd5a601f92beca186696d2cd09eee1a09b8ce9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/53608Reviewed-by: 's avatarJason Macnak <natsu@google.com> Reviewed-by: 's avatarChris Forbes <chrisforbes@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent b5924192
Showing with 0 additions and 2 deletions
src/Vulkan/android_vk_swiftshader.lds
# For Android, we must not export anything other than loader-related API # For Android, we must not export anything other than loader-related API
{ {
global: global:
vkGetInstanceProcAddr;
# Loader-ICD interface functions # Loader-ICD interface functions
vk_icdGetInstanceProcAddr; vk_icdGetInstanceProcAddr;
vk_icdNegotiateLoaderICDInterfaceVersion; vk_icdNegotiateLoaderICDInterfaceVersion;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment