Skip to content

S
swiftshader
Commit 3639df14 by Nicolas Capens Committed by Nicolas Capens
Options

Support 64-bit call targets.

The x86-64 call instruction only supports 32-bit IP-relative direct calls or 64-bit indirect calls. So handle 64-bit direct calls by storing the value into a register and making an indirect call. Bug chromium:860533 Change-Id: I3781d1e8a489ce9ab7c17b098ffe830cae62477e Reviewed-on: https://swiftshader-review.googlesource.com/19828Tested-by: 's avatarNicolas Capens <nicolascapens@google.com> Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
parent fbba4900
Showing with 10 additions and 3 deletions
third_party/subzero/src/IceTargetLoweringX8664.cpp
......@@ -685,12 +685,19 @@ Inst *TargetX8664::emitCallToTarget(Operand *CallTarget, Variable *ReturnReg) {
Context.insert(ReturnAddress);
} else {
if (CallTargetR != nullptr) {
// x86-64 in Subzero is ILP32. Therefore, CallTarget is i32, but the
// emitted call needs a i64 register (for textual asm.)
if (CallTargetR != nullptr && CallTarget->getType() == IceType_i32) {
// x86-64 in PNaCl is ILP32. Therefore, CallTarget is i32, but the
// emitted call needs an i64 register (for textual asm.)
Variable *T = makeReg(IceType_i64);
_movzx(T, CallTargetR);
CallTarget = T;
} else if (llvm::isa<Constant>(CallTarget) &&
CallTarget->getType() == IceType_i64) {
// x86-64 does not support 64-bit direct calls, so write the value
// to a register and make an indirect call.
Variable *T = makeReg(IceType_i64);
_mov(T, CallTarget);
CallTarget = T;
}
NewCall = Context.insert<Traits::Insts::Call>(ReturnReg, CallTarget);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment