Fix symbol visibility for preemption.

Entry functions need to have default visibility instead of protected visibility to allow symbol preemption during linking (i.e. when not using dlsym() to explicitly obtain pointers to entry functions). See: https://bugs.llvm.org//show_bug.cgi?id=30960 Bug swiftshader:64 Change-Id: Ia2d3ae8fb4faec9a75d811c643e3164bfb7d0423 Reviewed-on: https://swiftshader-review.googlesource.com/10028Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <capn@google.com> Tested-by: Nicolas Capens <capn@google.com>

Fix symbol visibility for preemption.
3a1674d1 · Nicolas Capens · df0be385 · 3a1674d1 · 3a1674d1
Commit 3a1674d1 authored Jun 09, 2017 by Nicolas Capens
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 13 deletions

BUILD.gn src/OpenGL/libEGL/BUILD.gn +4 -7

BUILD.gn src/OpenGL/libGLESv2/BUILD.gn +1 -6

No files found.
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -35,13 +35,10 @@ config("swiftshader_libEGL_private_config") {
      cflags += [ "-Wno-unused-but-set-variable" ]
    }
-    defines += [ "LOG_TAG=\"swiftshader_libEGL\"" ]
+    defines += [
+      "LOG_TAG=\"swiftshader_libEGL\"",
-    if (is_linux) {
+      "EGLAPI=__attribute__((visibility(\"default\")))",
-      defines += [ "EGLAPI=__attribute__((visibility(\"protected\")))" ]
+    ]
-    } else {
-      defines += [ "EGLAPI=__attribute__((visibility(\"default\")))" ]
-    }
  }
 }

--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -49,13 +49,8 @@ config("swiftshader_libGLESv2_private_config") {
      "LOG_TAG=\"swiftshader_libGLESv2\"",
      "__STDC_CONSTANT_MACROS",
      "__STDC_LIMIT_MACROS",
+      "GL_APICALL=__attribute__((visibility(\"default\")))",
    ]
-    if (is_linux) {
-      defines += [ "GL_APICALL=__attribute__((visibility(\"protected\")))" ]
-    } else {
-      defines += [ "GL_APICALL=__attribute__((visibility(\"default\")))" ]
-    }
  }
 }