Commit 3b4dc93e by Jim Stichnoth

Subzero: Shorten global prefixes in non-DUMP build.

Reverts part of 843142fe (https://codereview.chromium.org/1776343004). Makes global prefixes short in all non-DUMP builds, not just the browser build, so that the user doesn't need to remember to supply the override options in a command-line MINIMAL build. BUG= none R=jpp@chromium.org Review URL: https://codereview.chromium.org/1805593002 .
parent bd2e2315
......@@ -172,13 +172,6 @@ void BrowserCompileServer::getParsedFlags(uint32_t NumThreads, int argc,
Flags->setUseSandboxing(true);
Flags->setOutFileType(FT_Elf);
Flags->setTargetArch(getTargetArch());
// Make the prefixes short to reduce the chance that string construction will
// have to resort to malloc(). Note that this won't change anything if the
// pexe was finalize with "--no-strip-syms". TODO(stichnot): This will be
// unnecessary when we stop directly constructing strings that are used for
// names and lookup keys.
Flags->setDefaultFunctionPrefix("F");
Flags->setDefaultGlobalPrefix("G");
ExtraFlags->setBuildOnRead(true);
ExtraFlags->setInputFileFormat(llvm::PNaClFormat);
}
......
......@@ -84,14 +84,14 @@ cl::opt<std::string>
DefaultFunctionPrefix("default-function-prefix",
cl::desc("Define default function prefix for naming "
"unnamed functions"),
cl::init("Function"));
cl::init(Ice::BuildDefs::dump() ? "Function" : "F"));
/// Define default global prefix for naming unnamed globals.
cl::opt<std::string>
DefaultGlobalPrefix("default-global-prefix",
cl::desc("Define default global prefix for naming "
"unnamed globals"),
cl::init("Global"));
cl::init(Ice::BuildDefs::dump() ? "Global" : "G"));
/// Disable hybrid assembly when -filetype=iasm.
cl::opt<bool> DisableHybridAssembly(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment