Skip to content

S
swiftshader
Commit 45be4684 by Nicolas Capens Committed by Nicolas Capens
Options

Remove typeinfo from Vulkan exported symbols

Exporting all typeinfo was copied over from the GLES version scripts which addressed crbug.com/737384. However, this can lead to ODR violations, and we have several other solutions in place for avoiding UBSan failures. Remove it entirely for now. If this causes a regression and we still have to export some typeinfo, we should do so selectively. For example to only export typeinfo for objects in the vk namespace: _ZTS*vk*; _ZTI*vk*; Alternatively, or in addition, we can try using '-mllvm -asan-use-private-alias=1'. Bug: b/155441530 Change-Id: I07303ac01b05d02b879fff829b6a9945c16fdf82 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44689 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent cd09f8e9
Showing with 0 additions and 12 deletions
src/Vulkan/android_vk_swiftshader.lds
...@@ -7,10 +7,6 @@ global: ...@@ -7,10 +7,6 @@ global:
vk_icdGetInstanceProcAddr; vk_icdGetInstanceProcAddr;
vk_icdNegotiateLoaderICDInterfaceVersion; vk_icdNegotiateLoaderICDInterfaceVersion;
# Type-strings and type-infos required by sanitizers
_ZTS*;
_ZTI*;
# Android HAL module info object # Android HAL module info object
HMI; HMI;
......
src/Vulkan/fuchsia_vk_swiftshader.lds
...@@ -10,10 +10,6 @@ global: ...@@ -10,10 +10,6 @@ global:
vk_icdNegotiateLoaderICDInterfaceVersion; vk_icdNegotiateLoaderICDInterfaceVersion;
vk_icdInitializeConnectToServiceCallback; vk_icdInitializeConnectToServiceCallback;
# Type-strings and type-infos required by sanitizers
_ZTS*;
_ZTI*;
local: local:
*; *;
}; };
......
src/Vulkan/vk_swiftshader.lds
...@@ -215,10 +215,6 @@ global: ...@@ -215,10 +215,6 @@ global:
vkGetPhysicalDeviceSurfaceFormatsKHR; vkGetPhysicalDeviceSurfaceFormatsKHR;
vkGetPhysicalDeviceSurfacePresentModesKHR; vkGetPhysicalDeviceSurfacePresentModesKHR;
# Type-strings and type-infos required by sanitizers
_ZTS*;
_ZTI*;
# Android HAL module info object # Android HAL module info object
HMI; HMI;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment