Commit 4ef71eb8 by Alexis Hetu Committed by Alexis Hétu

Change scissor type from sw::Rect to VkRect2D

Removed sw::Rect from Renderer. Bug b/126883332 Change-Id: I01ff418745c19739b4692c7cec56ae54fe91a8fc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27109Tested-by: 's avatarAlexis Hétu <sugoi@google.com> Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
parent 9705dec5
...@@ -438,10 +438,10 @@ namespace sw ...@@ -438,10 +438,10 @@ namespace sw
// Scissor // Scissor
{ {
data->scissorX0 = scissor.x0; data->scissorX0 = scissor.offset.x;
data->scissorX1 = scissor.x1; data->scissorX1 = scissor.offset.x + scissor.extent.width;
data->scissorY0 = scissor.y0; data->scissorY0 = scissor.offset.y;
data->scissorY1 = scissor.y1; data->scissorY1 = scissor.offset.y + scissor.extent.height;
} }
draw->primitive = 0; draw->primitive = 0;
...@@ -1604,7 +1604,7 @@ namespace sw ...@@ -1604,7 +1604,7 @@ namespace sw
this->viewport = viewport; this->viewport = viewport;
} }
void Renderer::setScissor(const Rect &scissor) void Renderer::setScissor(const VkRect2D &scissor)
{ {
this->scissor = scissor; this->scissor = scissor;
} }
......
...@@ -267,7 +267,7 @@ namespace sw ...@@ -267,7 +267,7 @@ namespace sw
// Viewport & Clipper // Viewport & Clipper
void setViewport(const VkViewport &viewport); void setViewport(const VkViewport &viewport);
void setScissor(const Rect &scissor); void setScissor(const VkRect2D &scissor);
void addQuery(Query *query); void addQuery(Query *query);
void removeQuery(Query *query); void removeQuery(Query *query);
...@@ -311,7 +311,7 @@ namespace sw ...@@ -311,7 +311,7 @@ namespace sw
Clipper *clipper; Clipper *clipper;
Blitter *blitter; Blitter *blitter;
VkViewport viewport; VkViewport viewport;
Rect scissor; VkRect2D scissor;
int clipFlags; int clipFlags;
Triangle *triangleBatch[16]; Triangle *triangleBatch[16];
......
...@@ -57,11 +57,6 @@ sw::DrawType Convert(VkPrimitiveTopology topology) ...@@ -57,11 +57,6 @@ sw::DrawType Convert(VkPrimitiveTopology topology)
return sw::DRAW_TRIANGLELIST; return sw::DRAW_TRIANGLELIST;
} }
sw::Rect Convert(const VkRect2D& rect)
{
return sw::Rect(rect.offset.x, rect.offset.y, rect.offset.x + rect.extent.width, rect.offset.y + rect.extent.height);
}
sw::StreamType getStreamType(VkFormat format) sw::StreamType getStreamType(VkFormat format)
{ {
switch(format) switch(format)
...@@ -331,7 +326,7 @@ GraphicsPipeline::GraphicsPipeline(const VkGraphicsPipelineCreateInfo* pCreateIn ...@@ -331,7 +326,7 @@ GraphicsPipeline::GraphicsPipeline(const VkGraphicsPipelineCreateInfo* pCreateIn
UNIMPLEMENTED(); UNIMPLEMENTED();
} }
scissor = Convert(viewportState->pScissors[0]); scissor = viewportState->pScissors[0];
viewport = viewportState->pViewports[0]; viewport = viewportState->pViewports[0];
} }
...@@ -517,7 +512,7 @@ const sw::Context& GraphicsPipeline::getContext() const ...@@ -517,7 +512,7 @@ const sw::Context& GraphicsPipeline::getContext() const
return context; return context;
} }
const sw::Rect& GraphicsPipeline::getScissor() const const VkRect2D& GraphicsPipeline::getScissor() const
{ {
return scissor; return scissor;
} }
......
...@@ -71,7 +71,7 @@ public: ...@@ -71,7 +71,7 @@ public:
uint32_t computePrimitiveCount(uint32_t vertexCount) const; uint32_t computePrimitiveCount(uint32_t vertexCount) const;
const sw::Context& getContext() const; const sw::Context& getContext() const;
const sw::Rect& getScissor() const; const VkRect2D& getScissor() const;
const VkViewport& getViewport() const; const VkViewport& getViewport() const;
const sw::Color<float>& getBlendConstants() const; const sw::Color<float>& getBlendConstants() const;
...@@ -80,7 +80,7 @@ private: ...@@ -80,7 +80,7 @@ private:
sw::SpirvShader *fragmentShader = nullptr; sw::SpirvShader *fragmentShader = nullptr;
sw::Context context; sw::Context context;
sw::Rect scissor; VkRect2D scissor;
VkViewport viewport; VkViewport viewport;
sw::Color<float> blendConstants; sw::Color<float> blendConstants;
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment