Fix for MSAN issues

Chromium's memory sanitizer doesn't work with JIT compiled code, so we have to skip blitReactor when using MSAN, otherwise most uses of glReadPixels() will cause MSAN to detect a false use-of-uninitialized-value, since it doesn't instrument the inside of JIT compiled code. Bug chromium:848035 chromium:860533 Change-Id: Idfa194ce0fcd41eb7acf7868cbcebfc04d598f5b Reviewed-on: https://swiftshader-review.googlesource.com/19808Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com>

Fix for MSAN issues
551478a9 · Alexis Hetu · Alexis Hétu · e1fa9ea7 · 551478a9
Commit 551478a9 authored Jul 05, 2018 by Alexis Hetu Committed by Alexis Hétu Jul 06, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

Blitter.cpp src/Renderer/Blitter.cpp +7 -4

No files found.
--- a/src/Renderer/Blitter.cpp
+++ b/src/Renderer/Blitter.cpp
@@ -141,10 +141,13 @@ namespace sw
 			return;
 		}
-		if(blitReactor(source, sourceRect, dest, destRect, options))
+		// The memory sanitizer doesn't work with JIT compiled code
-		{
+		#if !defined(MEMORY_SANITIZER)
-			return;
+			if(blitReactor(source, sourceRect, dest, destRect, options))
-		}
+			{
+				return;
+			}
+		#endif
 		SliceRectF sRect = sourceRect;
 		SliceRect dRect = destRect;