Skip to content

S
swiftshader
Commit 59a29e3c by Antonio Maiorano
Options

Regres: fix no env-vars for deqp on Windows

The environment variables were being modified incorrectly, introducing blank lines, which Windows doesn't like, leading to the spawned deqp process having a blank env var table. Change-Id: Id034594219397809667670f9f7fb26f67ee7d87c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40888Reviewed-by: 's avatarBen Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: 's avatarAntonio Maiorano <amaiorano@google.com>
parent ddee0f34
Showing with 1 addition and 1 deletion
tests/regres/deqp/deqp.go
......@@ -255,7 +255,7 @@ func (c *Config) TestRoutine(exe string, tests <-chan string, results chan<- Tes
// For example, GCOV_PREFIX="/tmp/gcov_output/PROC_ID" becomes GCOV_PREFIX="/tmp/gcov_output/1" in the first go routine.
// You might expect PROC_ID to be the process ID of some process, but the only real requirement is that
// it is a unique ID between the *parallel* child processes.
env := make([]string, len(c.Env))
env := make([]string, 0, len(c.Env))
for _, v := range c.Env {
if strings.HasPrefix(v, "GCOV_PREFIX=") {
v = strings.ReplaceAll(v, "PROC_ID", strconv.Itoa(goroutineIndex))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment