Assert there are no unmatched eglBindTexImage/eglReleaseTexImage

Two consecutive eglBindTexImage calls on the same buffer (texture) would eventually result in a crash if the texture is released before the egl surfaces, so this assert is meant to perform an early detection of a harder to detect future issue. Bug chromium:932986 chromium:929088 Change-Id: I10b3892fe06d491c8a0a09dec84678b25f49c6ab Reviewed-on: https://swiftshader-review.googlesource.com/c/25128Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Assert there are no unmatched eglBindTexImage/eglReleaseTexImage
5efe6118 · Alexis Hetu · Alexis Hétu · e2d8b128 · 5efe6118 · 5efe6118
Commit 5efe6118 authored Feb 20, 2019 by Alexis Hetu Committed by Alexis Hétu Feb 25, 2019
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

Texture.cpp src/OpenGL/libGLES_CM/Texture.cpp +2 -0

Texture.cpp src/OpenGL/libGLESv2/Texture.cpp +2 -0

No files found.
--- a/src/OpenGL/libGLES_CM/Texture.cpp
+++ b/src/OpenGL/libGLES_CM/Texture.cpp
@@ -450,6 +450,8 @@ void Texture2D::bindTexImage(gl::Surface *surface)
 	image[0] = surface->getRenderTarget();
+	assert(!mSurface); // eglBindTexImage called before eglReleaseTexImage
 	mSurface = surface;
 	mSurface->setBoundTexture(this);
 }

--- a/src/OpenGL/libGLESv2/Texture.cpp
+++ b/src/OpenGL/libGLESv2/Texture.cpp
@@ -561,6 +561,8 @@ void Texture2D::bindTexImage(gl::Surface *surface)
 	image[0] = surface->getRenderTarget();
+	assert(!mSurface); // eglBindTexImage called before eglReleaseTexImage
 	mSurface = surface;
 	mSurface->setBoundTexture(this);
 }