Fix thread-local storage memory leak.

eglReleaseThread() was leaking some memory because even though it deletes the 'current' thread state, it was inadvertently getting re-allocated when recording the success error state. Change-Id: I92efb1b34e62a21998b4fc19aaeba6473b06548b Reviewed-on: https://swiftshader-review.googlesource.com/11968Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com>

Fix thread-local storage memory leak.
660eba9a · Nicolas Capens · Nicolas Capens · 69674fb1 · 660eba9a
Commit 660eba9a authored Sep 05, 2017 by Nicolas Capens Committed by Nicolas Capens Sep 05, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

libEGL.cpp src/OpenGL/libEGL/libEGL.cpp +1 -1

No files found.
--- a/src/OpenGL/libEGL/libEGL.cpp
+++ b/src/OpenGL/libEGL/libEGL.cpp
@@ -488,7 +488,7 @@ EGLBoolean ReleaseThread(void)
 	detachThread();
-	return success(EGL_TRUE);
+	return EGL_TRUE;   // success() is not called here because it would re-allocate thread-local storage.
 }
 EGLSurface CreatePbufferFromClientBuffer(EGLDisplay dpy, EGLenum buftype, EGLClientBuffer buffer, EGLConfig config, const EGLint *attrib_list)