Release surface on releaseTexImage

The surface set during bindTexImage should be unset during releaseTexImage. Failing to do so may keep a dangling pointer to the surface, which can cause a crash later on (this was hit during the testing of new unit tests which will be added soon). Change-Id: Ic258fff8c880d449add825c5e9185435cc4ea419 Reviewed-on: https://swiftshader-review.googlesource.com/17548Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Release surface on releaseTexImage
749ac9c8 · Alexis Hetu · Alexis Hétu · 2acbd268 · 749ac9c8
Commit 749ac9c8 authored Mar 01, 2018 by Alexis Hetu Committed by Alexis Hétu Mar 01, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

Texture.cpp src/OpenGL/libGLESv2/Texture.cpp +6 -0

No files found.
--- a/src/OpenGL/libGLESv2/Texture.cpp
+++ b/src/OpenGL/libGLESv2/Texture.cpp
@@ -572,6 +572,12 @@ void Texture2D::releaseTexImage()
 			image[level] = nullptr;
 		}
 	}
+
+	if(mSurface)
+	{
+		mSurface->setBoundTexture(nullptr);
+		mSurface = nullptr;
+	}
 }

 void Texture2D::setCompressedImage(GLint level, GLenum format, GLsizei width, GLsizei height, GLsizei imageSize, const void *pixels)