Allow Blitter::fastClear to directly write to external buffer

When the external buffer is the one that is dirty, avoid a useless copy from external to internal before fast clearing the buffer by clearing the external buffer directly. Change-Id: I469243ba8a2b8617f9a0f8b6e2a089f667b8ae63 Reviewed-on: https://swiftshader-review.googlesource.com/18033Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Allow Blitter::fastClear to directly write to external buffer
7622b96a · Alexis Hetu · Alexis Hétu · 53e83aa8 · 7622b96a
Commit 7622b96a authored Mar 25, 2018 by Alexis Hetu Committed by Alexis Hétu Mar 26, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

Blitter.cpp src/Renderer/Blitter.cpp +6 -5

No files found.
--- a/src/Renderer/Blitter.cpp
+++ b/src/Renderer/Blitter.cpp
@@ -99,7 +99,8 @@ namespace sw
 			return false;
 		}

-		uint8_t *slice = (uint8_t*)dest->lockInternal(dRect.x0, dRect.y0, dRect.slice, sw::LOCK_WRITEONLY, sw::PUBLIC);
+		bool useDestInternal = !dest->isExternalDirty();
+		uint8_t *slice = (uint8_t*)dest->lock(dRect.x0, dRect.y0, dRect.slice, sw::LOCK_WRITEONLY, sw::PUBLIC, useDestInternal);

 		for(int j = 0; j < dest->getSamples(); j++)
 		{
@@ -111,24 +112,24 @@ namespace sw
 				for(int i = dRect.y0; i < dRect.y1; i++)
 				{
 					sw::clear((uint16_t*)d, packed, dRect.x1 - dRect.x0);
-					d += dest->getInternalPitchB();
+					d += dest->getPitchB(useDestInternal);
 				}
 				break;
 			case 4:
 				for(int i = dRect.y0; i < dRect.y1; i++)
 				{
 					sw::clear((uint32_t*)d, packed, dRect.x1 - dRect.x0);
-					d += dest->getInternalPitchB();
+					d += dest->getPitchB(useDestInternal);
 				}
 				break;
 			default:
 				assert(false);
 			}

-			slice += dest->getInternalSliceB();
+			slice += dest->getSliceB(useDestInternal);
 		}

-		dest->unlockInternal();
+		dest->unlock(useDestInternal);

 		return true;
 	}