Share ANGLE_DISABLE_TRACE-setting code between win and non-win

No behavior change. Change-Id: Ibe79440616b7d37ba621b718c448bb9c6bad9b78 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55631Tested-by: Nico Weber <thakis@chromium.org> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Commit-Queue: Nico Weber <thakis@chromium.org>

Share ANGLE_DISABLE_TRACE-setting code between win and non-win
766eb919 · Nico Weber · swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com · 6f0ce128 · 766eb919
Commit 766eb919 authored Jul 08, 2021 by Nico Weber Committed by swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com Jul 08, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

BUILD.gn BUILD.gn +4 -6

No files found.
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -21,6 +21,10 @@ import("src/Reactor/reactor.gni")
 config("swiftshader_config") {
  defines = []

+  if (!is_debug) {
+    defines += [ "ANGLE_DISABLE_TRACE" ]
+  }
+
  if (is_win) {
    defines += [
      "_WINDLL",
@@ -31,10 +35,6 @@ config("swiftshader_config") {
      "_ENABLE_EXTENDED_ALIGNED_STORAGE",
    ]

-    if (!is_debug) {
-      defines += [ "ANGLE_DISABLE_TRACE" ]
-    }
-
    # Diable some MSVC warnings.
    if (!is_clang) {
      cflags += [
@@ -54,8 +54,6 @@ config("swiftshader_config") {

    if (!is_debug) {
      cflags += [ "-Os" ]
-
-      defines += [ "ANGLE_DISABLE_TRACE" ]
    }

    if (current_cpu == "x64") {  # 64 bit version