Skip to content

S
swiftshader
Commit 793050e8 by Chris Forbes
Options

Fix BuiltInSubgroupSize in graphics pipeline

This had previously been masked by other failures, so we didn't notice. Bitcasting Int to Float4 is incorrect. Test: dEQP-VK.subgroups.* Change-Id: Ib66fb3a458d44c6689977006454bbc7719a1373f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30089Tested-by: 's avatarChris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by: 's avatarBen Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
parent f40cff91
Showing with 2 additions and 2 deletions
src/Pipeline/PixelProgram.cpp
......@@ -41,7 +41,7 @@ namespace sw
if (it != spirvShader->inputBuiltins.end())
{
ASSERT(it->second.SizeInComponents == 1);
routine.getVariable(it->second.Id)[it->second.FirstComponent] = As<SIMD::Float>(Int(SIMD::Width));
routine.getVariable(it->second.Id)[it->second.FirstComponent] = As<SIMD::Float>(SIMD::Int(SIMD::Width));
}
it = spirvShader->inputBuiltins.find(spv::BuiltInSubgroupLocalInvocationId);
......
src/Pipeline/VertexProgram.cpp
......@@ -50,7 +50,7 @@ namespace sw
if (it != spirvShader->inputBuiltins.end())
{
ASSERT(it->second.SizeInComponents == 1);
routine.getVariable(it->second.Id)[it->second.FirstComponent] = As<SIMD::Float>(Int(SIMD::Width));
routine.getVariable(it->second.Id)[it->second.FirstComponent] = As<SIMD::Float>(SIMD::Int(SIMD::Width));
}
it = spirvShader->inputBuiltins.find(spv::BuiltInSubgroupLocalInvocationId);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment