Fix implicit inexact conversion

Clang 10's -Wimplicit-int-float-conversion complains that MAX = 2147483647 cannot be exactly represented as a float. Use an explicit conversion to suppress the warning locally. Note that this value's usage to produce a random boolean doesn't critically depend on exact conversion. Bug: b/152777669 Change-Id: I1136ca16dcb842b97f4a76a6ed3e1c3333e814f8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/51488Tested-by: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>

Fix implicit inexact conversion
7b2f9389 · Nicolas Capens · swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com · b9e179f1 · 7b2f9389
Commit 7b2f9389 authored Jan 06, 2021 by Nicolas Capens Committed by swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com Jan 07, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

IceRNG.cpp third_party/subzero/src/IceRNG.cpp +1 -1

No files found.
--- a/third_party/subzero/src/IceRNG.cpp
+++ b/third_party/subzero/src/IceRNG.cpp
@@ -50,7 +50,7 @@ uint64_t RandomNumberGenerator::next(uint64_t Max) {
 }

 bool RandomNumberGeneratorWrapper::getTrueWithProbability(float Probability) {
-  return RNG.next(MAX) < Probability * MAX;
+  return static_cast<float>(RNG.next(MAX)) < Probability * static_cast<float>(MAX);
 }

 } // end of namespace Ice