Work around GCC bug in constexpr to attributes

__attribute__((aligned(MaxCacheLineSize))) triggers a GCC bug because enum {MaxCacheLineSize = 64 }; isn't constant enough. Adding zero to it makes it that much more constant. R= stichnot@chromium.org BUG= https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382 Review URL: https://codereview.chromium.org/867483004

Work around GCC bug in constexpr to attributes
867684e2 · JF Bastien · c34190c2 · 867684e2
Commit 867684e2 authored Jan 28, 2015 by JF Bastien
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

IceDefs.h src/IceDefs.h +3 -1

No files found.
--- a/src/IceDefs.h
+++ b/src/IceDefs.h
@@ -129,8 +129,10 @@ typedef uint32_t TimerIdT;
 enum { MaxCacheLineSize = 64 };
 // Use ICE_CACHELINE_BOUNDARY to force the next field in a declaration
 // list to be aligned to the next cache line.
+// Note: zero is added to work around the following GCC 4.8 bug (fixed in 4.9):
+//       https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55382
 #define ICE_CACHELINE_BOUNDARY                                                 \
-  __attribute__((aligned(MaxCacheLineSize))) int : 0
+  __attribute__((aligned(MaxCacheLineSize + 0))) int : 0

 // PNaCl is ILP32, so theoretically we should only need 32-bit offsets.
 typedef int32_t RelocOffsetT;