Skip to content

S
swiftshader
Commit 8835576b by Jan Voung
Options

Subzero: Remove a TODO comment about shld/shrd.

The 32-bit validator is now consistent with the 64-bit validator w.r.t. 16-bit shld/shrd and accepts it. We didn't really use the 16-bit form in Subzero though, only the 32-bit one for 64-bit ops, I think. BUG=none R=stichnot@chromium.org Review URL: https://codereview.chromium.org/696753003
parent 6c4fde96
Showing with 2 additions and 4 deletions
src/IceInstX8632.h
...@@ -993,8 +993,7 @@ private: ...@@ -993,8 +993,7 @@ private:
~InstX8632Mul() override {} ~InstX8632Mul() override {}
}; };
// Shld instruction - shift across a pair of operands. TODO: Verify // Shld instruction - shift across a pair of operands.
// that the validator accepts the shld instruction.
class InstX8632Shld : public InstX8632 { class InstX8632Shld : public InstX8632 {
InstX8632Shld(const InstX8632Shld &) = delete; InstX8632Shld(const InstX8632Shld &) = delete;
InstX8632Shld &operator=(const InstX8632Shld &) = delete; InstX8632Shld &operator=(const InstX8632Shld &) = delete;
...@@ -1016,8 +1015,7 @@ private: ...@@ -1016,8 +1015,7 @@ private:
~InstX8632Shld() override {} ~InstX8632Shld() override {}
}; };
// Shrd instruction - shift across a pair of operands. TODO: Verify // Shrd instruction - shift across a pair of operands.
// that the validator accepts the shrd instruction.
class InstX8632Shrd : public InstX8632 { class InstX8632Shrd : public InstX8632 {
InstX8632Shrd(const InstX8632Shrd &) = delete; InstX8632Shrd(const InstX8632Shrd &) = delete;
InstX8632Shrd &operator=(const InstX8632Shrd &) = delete; InstX8632Shrd &operator=(const InstX8632Shrd &) = delete;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment