Subzero: Allow extra args to be passed to llc and Subzero.

Use --llc to pass extra arguments to pnacl-translate. Use --sz to pass extra arguments to llvm2ice. The --stats argument is removed from the script because it is Subzero-only, and can now be done with --sz=--stats . BUG= none R=jvoung@chromium.org Review URL: https://codereview.chromium.org/582593002

Subzero: Allow extra args to be passed to llc and Subzero.
89906a5e · Jim Stichnoth · ff9c7063 · 89906a5e
Commit 89906a5e authored Sep 18, 2014 by Jim Stichnoth
Hide whitespace changes
Inline Side-by-side

Showing with 22 additions and 12 deletions

szbuild.py pydir/szbuild.py +22 -12

No files found.
--- a/pydir/szbuild.py
+++ b/pydir/szbuild.py
@@ -83,8 +83,10 @@ def AddOptionalArgs(argparser):
    argparser.add_argument('--verbose', '-v', dest='verbose',
                           action='store_true',
                           help='Display some extra debugging output')
-    argparser.add_argument('--stats', dest='stats', action='store_true',
+    argparser.add_argument('--sz', dest='sz_args', action='append', default=[],
-                           help='Enable Subzero stats output')
+                           help='Extra arguments for Subzero')
+    argparser.add_argument('--llc', dest='llc_args', action='append',
+                           default=[], help='Extra arguments for llc')
 def main():
    """Create a hybrid translation from Subzero and llc.
@@ -172,11 +174,15 @@ def ProcessPexe(args, pexe, exe):
    if args.force or NewerThanOrNotThere(pexe, obj_llc) or \
            NewerThanOrNotThere(llcbin, obj_llc):
        opt_level_map = { 'm1':'0', '-1':'0', '0':'0', '1':'1', '2':'2' }
-        shellcmd((
+        shellcmd(['pnacl-translate',
-            'pnacl-translate -ffunction-sections -c -arch x86-32-linux ' +
+                  '-ffunction-sections',
-            '-O{level} --pnacl-driver-append-LLC_FLAGS_EXTRA=-externalize ' +
+                  '-c',
-            '-o {obj} {pexe}'
+                  '-arch', 'x86-32-linux',
-            ).format(level=opt_level_map[opt_level], obj=obj_llc, pexe=pexe),
+                  '-O' + opt_level_map[opt_level],
+                  '--pnacl-driver-append-LLC_FLAGS_EXTRA=-externalize',
+                  '-o', obj_llc] +
+                 args.llc_args +
+                 [pexe],
                 echo=args.verbose)
        shellcmd((
            'objcopy --redefine-sym _start=_user_start {obj}'
@@ -186,11 +192,15 @@ def ProcessPexe(args, pexe, exe):
            ).format(obj=obj_llc, sym=sym_llc), echo=args.verbose)
    if args.force or NewerThanOrNotThere(pexe, obj_sz) or \
            NewerThanOrNotThere(llvm2ice, obj_sz):
-        shellcmd((
+        shellcmd([llvm2ice,
-            '{l2i} -O{level} -bitcode-format=pnacl -disable-globals ' +
+                  '-O' + opt_level,
-            '-externalize -ffunction-sections {pexe} -o {asm}' +
+                  '-bitcode-format=pnacl',
-            (' --stats' if args.stats else '')
+                  '-disable-globals',
-            ).format(l2i=llvm2ice, level=opt_level, pexe=pexe, asm=asm_sz),
+                  '-externalize',
+                  '-ffunction-sections',
+                  '-o', asm_sz] +
+                 args.sz_args +
+                 [pexe],
                 echo=args.verbose)
        shellcmd((
            'llvm-mc -arch=x86 -x86-asm-syntax=intel -filetype=obj -o {obj} ' +