Enable Reactor Print() in Debug/RelWithDebInfo builds

The rr::Print() functionality is intended for debugging, so it should always be available in Debug builds without having to set the CMake flag explicitly. This also helps us avoid inadvertently breaking it. Also consistently use TRUE/FALSE for Boolean values instead of a string. Bug: b/149328074 Change-Id: Iab7e0f230dcd5b42679d64ef75bf3c0a3809a0d0 Signed-off-by: Nicolas Capens <capn@google.com> Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/50076 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Antonio Maiorano <amaiorano@google.com>

Enable Reactor Print() in Debug/RelWithDebInfo builds
8dceaddf · Nicolas Capens · Nicolas Capens · e4c1a25c · 8dceaddf
Commit 8dceaddf authored Nov 06, 2020 by Nicolas Capens Committed by Nicolas Capens Nov 16, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 2 deletions

CMakeLists.txt CMakeLists.txt +7 -2

No files found.
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -554,10 +554,15 @@ if(SWIFTSHADER_WARNINGS_AS_ERRORS)
    endif()
 endif()

+# Enable Reactor Print() functionality in Debug/RelWithDebInfo builds or when explicitly enabled.
+if(CMAKE_BUILD_TYPE MATCHES "Deb")
+    set(REACTOR_ENABLE_PRINT TRUE)
+endif()
+
 if(REACTOR_EMIT_PRINT_LOCATION)
    # This feature depends on REACTOR_EMIT_DEBUG_INFO and REACTOR_ENABLE_PRINT
-    set(REACTOR_EMIT_DEBUG_INFO "On")
-    set(REACTOR_ENABLE_PRINT "On")
+    set(REACTOR_EMIT_DEBUG_INFO TRUE)
+    set(REACTOR_ENABLE_PRINT TRUE)
    list(APPEND SWIFTSHADER_COMPILE_OPTIONS "-DENABLE_RR_EMIT_PRINT_LOCATION")
 endif()