Skip to content

S
swiftshader
Commit 8e8e1d0d by Ben Clayton
Options

Shader: Add missing switch cases to operationString

These used to assert. Instead of asserting, let the compiler warn about unhandled cases - there's already a `return "<unknown>"` statement below the switch. Credit to Dan Sinclair who did all the hard work here. Bug: None - maintenance fix for legacy code Change-Id: I010a1d6228961a80a15523ff1a2c6db522b7756d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40833 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com> Tested-by: 's avatarBen Clayton <bclayton@google.com>
parent 3a2dfcbe
Showing with 2 additions and 2 deletions
src/Shader/Shader.cpp
......@@ -903,6 +903,7 @@ namespace sw
case OPCODE_TEXBIAS: return "texbias";
case OPCODE_TEXOFFSET: return "texoffset";
case OPCODE_TEXOFFSETBIAS: return "texoffsetbias";
case OPCODE_TEXLOD: return "texlod";
case OPCODE_TEXLODOFFSET: return "texlodoffset";
case OPCODE_TEXELFETCH: return "texelfetch";
case OPCODE_TEXELFETCHOFFSET: return "texelfetchoffset";
......@@ -992,8 +993,7 @@ namespace sw
case OPCODE_TEST: return "test";
case OPCODE_SWITCH: return "switch";
case OPCODE_ENDSWITCH: return "endswitch";
default:
ASSERT(false);
case OPCODE_SCALAR: return "scalar";
}
return "<unknown>";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment