Disallow assigning to interface block fields.

GLSL ES 3.0 interface blocks always have uniform storage qualification and thus can't be used as l-value. Change-Id: Iffe948dccbf2edb28eb1abe52a6f28dc76a1e84b Reviewed-on: https://swiftshader-review.googlesource.com/13929Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Disallow assigning to interface block fields.
91b425b2 · Nicolas Capens · Nicolas Capens · a4f0c896 · 91b425b2
Commit 91b425b2 authored Nov 15, 2017 by Nicolas Capens Committed by Nicolas Capens Nov 16, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

ParseHelper.cpp src/OpenGL/compiler/ParseHelper.cpp +1 -1

No files found.
--- a/src/OpenGL/compiler/ParseHelper.cpp
+++ b/src/OpenGL/compiler/ParseHelper.cpp
@@ -303,7 +303,6 @@ bool TParseContext::lValueErrorCheck(const TSourceLoc &line, const char* op, TIn
 		case EOpIndexDirect:
 		case EOpIndexIndirect:
 		case EOpIndexDirectStruct:
-		case EOpIndexDirectInterfaceBlock:
 			return lValueErrorCheck(line, op, binaryNode->getLeft());
 		case EOpVectorSwizzle:
 			errorReturn = lValueErrorCheck(line, op, binaryNode->getLeft());
@@ -326,6 +325,7 @@ bool TParseContext::lValueErrorCheck(const TSourceLoc &line, const char* op, TIn
 			}

 			return errorReturn;
+		case EOpIndexDirectInterfaceBlock:
 		default:
 			break;
 		}