GCC: readd visibility attributes for EGL/GLESv2

https://crbug.com/1122889 removed all defines for EGLAPI and GL_APICALL when compiled with GCC. However, that made all symbols of libEGL.so and libGLESv2.so hidden. Therefore SwiftShader can't be used with Chromium anymore. Bug: chromium:1122889 Change-Id: Ic05e7b5539537731141d945cf7944d07f4c389df Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55048 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Commit-Queue: Nicolas Capens <nicolascapens@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com>

GCC: readd visibility attributes for EGL/GLESv2
951192f3 · Stephan Hartmann · swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com · f679fc17 · 951192f3 · 951192f3
Commit 951192f3 authored Jun 20, 2021 by Stephan Hartmann Committed by swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com Jun 28, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

BUILD.gn src/OpenGL/libEGL/BUILD.gn +1 -1

BUILD.gn src/OpenGL/libGLESv2/BUILD.gn +1 -1

No files found.
--- a/src/OpenGL/libEGL/BUILD.gn
+++ b/src/OpenGL/libEGL/BUILD.gn
@@ -42,7 +42,7 @@ config("swiftshader_libEGL_private_config") {
    } else if (is_clang) {
      defines += [ "EGLAPI=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]
    } else {
-      defines += [ "EGLAPI= " ]
+      defines += [ "EGLAPI=__attribute__((visibility(\"protected\")))" ]
    }
  }
 }

--- a/src/OpenGL/libGLESv2/BUILD.gn
+++ b/src/OpenGL/libGLESv2/BUILD.gn
@@ -57,7 +57,7 @@ config("swiftshader_libGLESv2_private_config") {
    } else if (is_clang) {
      defines += [ "GL_APICALL=__attribute__((visibility(\"protected\"))) __attribute__((no_sanitize(\"function\")))" ]
    } else {
-      defines += [ "GL_APICALL= " ]
+      defines += [ "GL_APICALL=__attribute__((visibility(\"protected\")))" ]
    }
  }
 }