Skip to content

S
swiftshader
Commit 96f64045 by Ben Clayton
Options

Reactor: Remove the CallSupported capability.

Both LLVM and Subzero now support it, so there's no need to expose this as a capability. Yay! Bug: b/142132927 Change-Id: I5cf5eece809f7305d38e8d0f995be45d44a8b1cd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38449Tested-by: 's avatarBen Clayton <bclayton@google.com> Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
parent b7eb3a8a
Showing with 0 additions and 33 deletions
src/Reactor/LLVMReactor.cpp
...@@ -879,7 +879,6 @@ namespace rr ...@@ -879,7 +879,6 @@ namespace rr
{ {
const Capabilities Caps = const Capabilities Caps =
{ {
true, // CallSupported
true, // CoroutinesSupported true, // CoroutinesSupported
}; };
......
src/Reactor/Reactor.hpp
...@@ -58,7 +58,6 @@ namespace rr ...@@ -58,7 +58,6 @@ namespace rr
{ {
struct Capabilities struct Capabilities
{ {
bool CallSupported; // Support for rr::Call()
bool CoroutinesSupported; // Support for rr::Coroutine<F> bool CoroutinesSupported; // Support for rr::Coroutine<F>
}; };
extern const Capabilities Caps; extern const Capabilities Caps;
......
src/Reactor/ReactorUnitTests.cpp
...@@ -1136,12 +1136,6 @@ TEST(ReactorUnitTests, Args_GreaterThan5Mixed) ...@@ -1136,12 +1136,6 @@ TEST(ReactorUnitTests, Args_GreaterThan5Mixed)
TEST(ReactorUnitTests, Call) TEST(ReactorUnitTests, Call)
{ {
if (!rr::Caps.CallSupported)
{
SUCCEED() << "rr::Call() not supported";
return;
}
struct Class struct Class
{ {
static int Callback(Class *p, int i, float f) static int Callback(Class *p, int i, float f)
...@@ -1173,12 +1167,6 @@ TEST(ReactorUnitTests, Call) ...@@ -1173,12 +1167,6 @@ TEST(ReactorUnitTests, Call)
TEST(ReactorUnitTests, CallMemberFunction) TEST(ReactorUnitTests, CallMemberFunction)
{ {
if (!rr::Caps.CallSupported)
{
SUCCEED() << "rr::Call() not supported";
return;
}
struct Class struct Class
{ {
int Callback(int argI, float argF) int Callback(int argI, float argF)
...@@ -1210,12 +1198,6 @@ TEST(ReactorUnitTests, CallMemberFunction) ...@@ -1210,12 +1198,6 @@ TEST(ReactorUnitTests, CallMemberFunction)
TEST(ReactorUnitTests, CallMemberFunctionIndirect) TEST(ReactorUnitTests, CallMemberFunctionIndirect)
{ {
if (!rr::Caps.CallSupported)
{
SUCCEED() << "rr::Call() not supported";
return;
}
struct Class struct Class
{ {
int Callback(int argI, float argF) int Callback(int argI, float argF)
...@@ -1247,12 +1229,6 @@ TEST(ReactorUnitTests, CallMemberFunctionIndirect) ...@@ -1247,12 +1229,6 @@ TEST(ReactorUnitTests, CallMemberFunctionIndirect)
TEST(ReactorUnitTests, CallImplicitCast) TEST(ReactorUnitTests, CallImplicitCast)
{ {
if (!rr::Caps.CallSupported)
{
SUCCEED() << "rr::Call() not supported";
return;
}
struct Class struct Class
{ {
static void Callback(Class *c, const char* s) static void Callback(Class *c, const char* s)
...@@ -1278,12 +1254,6 @@ TEST(ReactorUnitTests, CallImplicitCast) ...@@ -1278,12 +1254,6 @@ TEST(ReactorUnitTests, CallImplicitCast)
TEST(ReactorUnitTests, CallExternalCallRoutine) TEST(ReactorUnitTests, CallExternalCallRoutine)
{ {
if (!rr::Caps.CallSupported)
{
SUCCEED() << "rr::Call() not supported";
return;
}
// routine1 calls Class::Func, passing it a pointer to routine2, and Class::Func calls routine2 // routine1 calls Class::Func, passing it a pointer to routine2, and Class::Func calls routine2
auto routine2 = [] { auto routine2 = [] {
......
src/Reactor/SubzeroReactor.cpp
...@@ -165,7 +165,6 @@ namespace rr ...@@ -165,7 +165,6 @@ namespace rr
{ {
const Capabilities Caps = const Capabilities Caps =
{ {
true, // CallSupported
false, // CoroutinesSupported false, // CoroutinesSupported
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment