Subzero: Enable errors for unused parameters.

Makefile.standalone

@@ -162,7 +162,7 @@ SB_TRANSLATE := $(PNACL_BIN_PATH)/pnacl-translate
 
 BASE_CXXFLAGS := -std=gnu++11 -Wall -Wextra -Werror -fno-rtti \
 	-fno-exceptions $(OPTLEVEL) $(ASSERTIONS) -g -pedantic \
-	-Wno-error=unused-parameter $(CXX_EXTRA)
+	$(CXX_EXTRA)
 
 CXXFLAGS := $(LLVM_CXXFLAGS) $(BASE_CXXFLAGS) $(CXX_DEFINES) $(HOST_FLAGS) \
 	$(STDLIB_FLAGS)

src/IceClFlags.cpp

@@ -16,7 +16,11 @@
 #include "IceClFlags.h"
 
 #include "IceClFlagsExtra.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/Support/CommandLine.h"
+#pragma clang diagnostic pop
 
 namespace cl = llvm::cl;
 

src/IceClFlagsExtra.h

@@ -15,7 +15,11 @@
 #define SUBZERO_SRC_ICECLFLAGSEXTRA_H
 
 #include "IceDefs.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/IRReader/IRReader.h"
+#pragma clang diagnostic pop
 
 namespace Ice {
 

src/IceCompileServer.cpp

@@ -17,6 +17,9 @@
 #include "IceClFlagsExtra.h"
 #include "IceELFStreamer.h"
 #include "IceGlobalContext.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 // Include code to handle converting textual bitcode records to binary (for
 // INPUT_IS_TEXTUAL_BITCODE).
 #include "llvm/Bitcode/NaCl/NaClBitcodeMungeUtils.h"
@@ -25,6 +28,7 @@
 #include "llvm/Support/Signals.h"
 #include "llvm/Support/SourceMgr.h"
 #include "llvm/Support/StreamingMemoryObject.h"
+#pragma clang diagnostic pop
 
 #include <fstream>
 #include <iostream>

src/IceCompiler.cpp

@@ -23,12 +23,16 @@
 #include "IceConverter.h"
 #include "IceELFObjectWriter.h"
 #include "PNaClTranslator.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"
 #include "llvm/IRReader/IRReader.h"
 #include "llvm/Support/SourceMgr.h"
 #include "llvm/Support/StreamingMemoryObject.h"
+#pragma clang diagnostic pop
 
 namespace Ice {
 

src/IceConverter.cpp

@@ -24,6 +24,9 @@
 #include "IceTargetLowering.h"
 #include "IceTypes.h"
 #include "IceTypeConverter.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/IR/Constant.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/DataLayout.h"
@@ -31,6 +34,7 @@
 #include "llvm/IR/Instructions.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/IR/Module.h"
+#pragma clang diagnostic pop
 
 // TODO(kschimpf): Remove two namespaces being visible at once.
 using namespace llvm;

src/IceGlobalContext.cpp

@@ -24,7 +24,11 @@
 #include "IceTargetLowering.h"
 #include "IceTimerTree.h"
 #include "IceTypes.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/Support/Timer.h"
+#pragma clang diagnostic pop
 
 #include <algorithm> // max()
 #include <cctype> // isdigit(), isupper()

src/IceGlobalInits.h

@@ -20,9 +20,13 @@
 #include "IceDefs.h"
 #include "IceGlobalContext.h"
 #include "IceTypes.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/Bitcode/NaCl/NaClBitcodeParser.h" // for NaClBitcodeRecord.
 #include "llvm/IR/CallingConv.h"
 #include "llvm/IR/GlobalValue.h" // for GlobalValue::LinkageTypes.
+#pragma clang diagnostic pop
 
 #include <memory>
 #include <utility>

src/IceTimerTree.cpp

@@ -15,7 +15,11 @@
 #include "IceTimerTree.h"
 
 #include "IceDefs.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/Support/Timer.h"
+#pragma clang diagnostic pop
 
 namespace Ice {
 

src/PNaClTranslator.cpp

@@ -23,6 +23,9 @@
 #include "IceGlobalInits.h"
 #include "IceInst.h"
 #include "IceOperand.h"
+
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/Bitcode/NaCl/NaClBitcodeDecoders.h"
 #include "llvm/Bitcode/NaCl/NaClBitcodeDefs.h"
@@ -32,6 +35,7 @@
 #include "llvm/Support/Format.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Support/raw_ostream.h"
+#pragma clang diagnostic pop
 
 namespace {
 using namespace llvm;

unittest/BitcodeMunge.h

@@ -15,7 +15,10 @@
 #ifndef SUBZERO_UNITTEST_BITCODEMUNGE_H
 #define SUBZERO_UNITTEST_BITCODEMUNGE_H
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/Bitcode/NaCl/NaClBitcodeMunge.h"
+#pragma clang diagnostic pop
 
 #include "IceClFlags.h"
 

unittest/IceParseInstsTest.cpp

@@ -9,9 +9,12 @@
 
 #include <string>
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunused-parameter"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/Bitcode/NaCl/NaClBitcodeParser.h"
 #include "llvm/Bitcode/NaCl/NaClLLVMBitCodes.h"
+#pragma clang diagnostic pop
 
 #include "BitcodeMunge.h"
 #include "unittests/Bitcode/NaClMungeTest.h"