Fix passing sampler offset operands unchanged

All sampler operands are passed through an array of float values. Offset operands are integers, but we were retrieving them from the SPIR-V constant object interpreted as floating-point data, and then creating Float constants from them. This may alter their bit pattern, specifically values corresponding to sNaN may become qNaN. Instead create Reactor integer constants and bitcast them to Float. Bug: b/140302841 Change-Id: I06aceb7b2a97d5f5ce9009f5ba97238602cdc126 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35910 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com>

Fix passing sampler offset operands unchanged
a070dcf0 · Nicolas Capens · Nicolas Capens · dc550b2d · a070dcf0
Commit a070dcf0 authored Sep 01, 2019 by Nicolas Capens Committed by Nicolas Capens Sep 12, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

SpirvShader.cpp src/Pipeline/SpirvShader.cpp +1 -1

No files found.
--- a/src/Pipeline/SpirvShader.cpp
+++ b/src/Pipeline/SpirvShader.cpp
@@ -5108,7 +5108,7 @@ namespace sw
 			for(uint32_t j = 0; j < offsetType.sizeInComponents; j++, i++)
 			{
-				in[i] = offsetValue.Float(j);  // Integer values, but transfered as float.
+				in[i] = As<SIMD::Float>(offsetValue.Int(j));  // Integer values, but transfered as float.
 			}
 		}