Subzero: Do some cleanup on the regalloc code.

No functional changes, as measured by identical spec2k asm output. 1. Use early "return" and "continue" to reduce "if" nesting. 2. Reflow comments to 80 columns (instead of presumably 79). 3. Add some BuildDefs::dump() tests to reduce translator code size. BUG= none R=kschimpf@google.com Review URL: https://codereview.chromium.org/1448773002 .

Subzero: Do some cleanup on the regalloc code.
a1da6ff9 · Jim Stichnoth · 6c4ad849 · a1da6ff9 · a1da6ff9
Commit a1da6ff9 authored Nov 16, 2015 by Jim Stichnoth
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

IceRegAlloc.cpp src/IceRegAlloc.cpp +0 -0

IceTargetLowering.cpp src/IceTargetLowering.cpp +5 -0

No files found.
--- a/src/IceRegAlloc.cpp
+++ b/src/IceRegAlloc.cpp
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -293,6 +293,11 @@ void TargetLowering::regAlloc(RegAllocKind Kind) {
      Repeat = false;
    Kind = RAK_SecondChance;
  } while (Repeat);
+  // TODO(stichnot): Run the register allocator one more time to do stack slot
+  // coalescing.  The idea would be to initialize the Unhandled list with the
+  // set of Variables that have no register and a non-empty live range, and
+  // model an infinite number of registers.  Maybe use the register aliasing
+  // mechanism to get better packing of narrower slots.
 }

 void TargetLowering::markRedefinitions() {