Skip to content

S
swiftshader
Commit a6940c8e by Alexis Hetu Committed by Alexis Hétu
Options

Regres: Roll deqp forward to latest 1.2.1

The 37 failures in dEQP-VK.texture.explicit_lod.2d.* originated from a dEQP test issue which is now fixed: https://github.com/KhronosGroup/VK-GL-CTS/commit/ad89e118084d08fa1f14ad5801b996c62eb113cc Bug: b/151214291 Change-Id: I383a859945141ed04e4c49bab47a43692d02c060 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45668Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: 's avatarAlexis Hétu <sugoi@google.com>
parent 45510ad8
Showing with 30 additions and 30 deletions
tests/regres/deqp.json
{ {
"remote": "https://android.googlesource.com/platform/external/deqp", "remote": "https://android.googlesource.com/platform/external/deqp",
"sha": "2389f7642e2200423aa640ac4a68d089bef79c85", "sha": "c02d55cac0039a007e8e9e84bf0eb451a0ab5058",
"patches": [ "patches": [
"tests/regres/deqp-patches/deqp-x11.patch" "tests/regres/deqp-patches/deqp-x11.patch"
] ]
......
tests/regres/testlists/vk-master-FAIL.txt
dEQP-VK.texture.explicit_lod.2d.formats.a1r5g5b5_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.formats.a2b10g10r10_unorm_pack32_linear
dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.formats.r5g6b5_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_linear_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_nearest_repeat
tests/regres/testlists/vk-master-PASS.txt
...@@ -150810,12 +150810,15 @@ dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_linear_mipmap_linear ...@@ -150810,12 +150810,15 @@ dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_linear_mipmap_linear
dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_linear_mipmap_nearest dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_linear_mipmap_nearest
dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_nearest_mipmap_linear dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_nearest_mipmap_linear
dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_nearest_mipmap_nearest dEQP-VK.texture.explicit_lod.2d.derivatives.nearest_nearest_mipmap_nearest
dEQP-VK.texture.explicit_lod.2d.formats.a1r5g5b5_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.formats.a1r5g5b5_unorm_pack16_nearest dEQP-VK.texture.explicit_lod.2d.formats.a1r5g5b5_unorm_pack16_nearest
dEQP-VK.texture.explicit_lod.2d.formats.a2b10g10r10_unorm_pack32_linear
dEQP-VK.texture.explicit_lod.2d.formats.a2b10g10r10_unorm_pack32_nearest dEQP-VK.texture.explicit_lod.2d.formats.a2b10g10r10_unorm_pack32_nearest
dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_snorm_pack32_linear dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_snorm_pack32_linear
dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_snorm_pack32_nearest dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_snorm_pack32_nearest
dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_unorm_pack32_linear dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_unorm_pack32_linear
dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_unorm_pack32_nearest dEQP-VK.texture.explicit_lod.2d.formats.a8b8g8r8_unorm_pack32_nearest
dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4_unorm_pack16_nearest dEQP-VK.texture.explicit_lod.2d.formats.b4g4r4a4_unorm_pack16_nearest
dEQP-VK.texture.explicit_lod.2d.formats.b8g8r8a8_unorm_linear dEQP-VK.texture.explicit_lod.2d.formats.b8g8r8a8_unorm_linear
dEQP-VK.texture.explicit_lod.2d.formats.b8g8r8a8_unorm_nearest dEQP-VK.texture.explicit_lod.2d.formats.b8g8r8a8_unorm_nearest
...@@ -150831,6 +150834,7 @@ dEQP-VK.texture.explicit_lod.2d.formats.r32g32_sfloat_linear ...@@ -150831,6 +150834,7 @@ dEQP-VK.texture.explicit_lod.2d.formats.r32g32_sfloat_linear
dEQP-VK.texture.explicit_lod.2d.formats.r32g32_sfloat_nearest dEQP-VK.texture.explicit_lod.2d.formats.r32g32_sfloat_nearest
dEQP-VK.texture.explicit_lod.2d.formats.r32g32b32a32_sfloat_linear dEQP-VK.texture.explicit_lod.2d.formats.r32g32b32a32_sfloat_linear
dEQP-VK.texture.explicit_lod.2d.formats.r32g32b32a32_sfloat_nearest dEQP-VK.texture.explicit_lod.2d.formats.r32g32b32a32_sfloat_nearest
dEQP-VK.texture.explicit_lod.2d.formats.r5g6b5_unorm_pack16_linear
dEQP-VK.texture.explicit_lod.2d.formats.r5g6b5_unorm_pack16_nearest dEQP-VK.texture.explicit_lod.2d.formats.r5g6b5_unorm_pack16_nearest
dEQP-VK.texture.explicit_lod.2d.formats.r8_snorm_linear dEQP-VK.texture.explicit_lod.2d.formats.r8_snorm_linear
dEQP-VK.texture.explicit_lod.2d.formats.r8_snorm_nearest dEQP-VK.texture.explicit_lod.2d.formats.r8_snorm_nearest
...@@ -150844,8 +150848,18 @@ dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_snorm_linear ...@@ -150844,8 +150848,18 @@ dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_snorm_linear
dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_snorm_nearest dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_snorm_nearest
dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_unorm_linear dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_unorm_linear
dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_unorm_nearest dEQP-VK.texture.explicit_lod.2d.formats.r8g8b8a8_unorm_nearest
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.128x128_nearest_nearest_mipmap_nearest_clamp
...@@ -150882,10 +150896,14 @@ dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_linear_clamp ...@@ -150882,10 +150896,14 @@ dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.2x3_nearest_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.31x55_nearest_nearest_mipmap_nearest_clamp
...@@ -150914,16 +150932,26 @@ dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_linear_clamp ...@@ -150914,16 +150932,26 @@ dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.32x64_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.32x64_nearest_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.3x7_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_linear_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.3x7_nearest_nearest_mipmap_nearest_clamp
...@@ -150950,6 +150978,7 @@ dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_linear_clamp ...@@ -150950,6 +150978,7 @@ dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_linear_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_nearest_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_linear_nearest_mipmap_nearest_repeat
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_nearest_clamp dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_linear_mipmap_nearest_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_nearest_mipmap_linear_clamp dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_nearest_mipmap_linear_clamp
dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_nearest_mipmap_linear_repeat dEQP-VK.texture.explicit_lod.2d.sizes.57x35_nearest_nearest_mipmap_linear_repeat
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment