Properly initializing image's memory

MSAN detected uninitialized memory which caused many test failures. This can be easily fixed by zeroing out the memory before calling XCreateImage. Change-Id: I913c818ef38446055af7fd6aa885028e5f3f8bfb Reviewed-on: https://swiftshader-review.googlesource.com/12388Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Properly initializing image's memory
aa2666f9 · Alexis Hetu · Alexis Hétu · aa8239a5 · aa2666f9
Commit aa2666f9 authored Sep 25, 2017 by Alexis Hetu Committed by Alexis Hétu Sep 26, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

FrameBufferX11.cpp src/Main/FrameBufferX11.cpp +5 -2

No files found.
--- a/src/Main/FrameBufferX11.cpp
+++ b/src/Main/FrameBufferX11.cpp
@@ -85,8 +85,11 @@ namespace sw
 		if(!mit_shm)
 		{
-			buffer = new char[width * height * 4];
+			int bytes_per_line = width * 4;
-			x_image = libX11->XCreateImage(x_display, visual, depth, ZPixmap, 0, buffer, width, height, 32, width * 4);
+			int bytes_per_image = height * bytes_per_line;
+			buffer = new char[bytes_per_image];
+			memset(buffer, 0, bytes_per_image);
+			x_image = libX11->XCreateImage(x_display, visual, depth, ZPixmap, 0, buffer, width, height, 32, bytes_per_line);
 		}
 	}