Yarn: Don't zero-initialize data in Pool<T>::Item::construct()

TIL: For POD type T, `new T` and `new T()` are not the same. new T() will zero initialize, which for large arrays can be very costly. Bug: b/139142453 Change-Id: I9a1a3ef1bb0a167d9955310d1cf331e917019397 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35569 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Ben Clayton <bclayton@google.com>

Yarn: Don't zero-initialize data in Pool<T>::Item::construct()
ac1912f1 · Ben Clayton · a9da772f · ac1912f1
Commit ac1912f1 authored Aug 27, 2019 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

Pool.hpp src/Yarn/Pool.hpp +1 -1

No files found.
--- a/src/Yarn/Pool.hpp
+++ b/src/Yarn/Pool.hpp
@@ -118,7 +118,7 @@ T* Pool<T>::Item::get()
 template <typename T>
 void Pool<T>::Item::construct()
 {
-    new (&data) T();
+    new (&data) T;
 }
 template <typename T>