Fix glDeleteSync validation

glDeleteSync can only delete an existing FenceSync object. Change-Id: Ieb78894175235cc97c67ff0324d59bb5d7619918 Reviewed-on: https://swiftshader-review.googlesource.com/13829Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Fix glDeleteSync validation
add96ad2 · Alexis Hetu · Alexis Hétu · c1ef1ada · add96ad2
Commit add96ad2 authored Nov 14, 2017 by Alexis Hetu Committed by Alexis Hétu Nov 15, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 0 deletions

libGLESv3.cpp src/OpenGL/libGLESv2/libGLESv3.cpp +10 -0

No files found.
--- a/src/OpenGL/libGLESv2/libGLESv3.cpp
+++ b/src/OpenGL/libGLESv2/libGLESv3.cpp
@@ -3053,10 +3053,20 @@ GL_APICALL void GL_APIENTRY glDeleteSync(GLsync sync)
 {
 	TRACE("(GLsync sync = %p)", sync);
+	if(!sync)
+	{
+		return;
+	}
 	es2::Context *context = es2::getContext();
 	if(context)
 	{
+		if(!context->getFenceSync(sync))
+		{
+			return error(GL_INVALID_VALUE);
+		}
 		context->deleteFenceSync(sync);
 	}
 }