Disabling the debugger wait dialog by default with Vulkan

For some reason, the Vulkan Loader prevents any dialog window from popping up, which means that loading the SwiftShader Vulkan DLL in Debug was always failing, unless a debugger was already attached (as is the case when running from within Visual Studio). The debugger wait dialog can still be easily enabled locally by setting the DEBUGGER_WAIT_DIALOG environment variable. Bug b/116336664 Change-Id: I7ce596c753506c806bf6b159685a72d0372f949a Reviewed-on: https://swiftshader-review.googlesource.com/c/22488Reviewed-by: Nicolas Capens <nicolascapens@google.com> Tested-by: Alexis Hétu <sugoi@google.com>

Disabling the debugger wait dialog by default with Vulkan
b3c4d88a · Alexis Hetu · Alexis Hétu · 6ed398b4 · b3c4d88a
Commit b3c4d88a authored Nov 13, 2018 by Alexis Hetu Committed by Alexis Hétu Nov 13, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

vulkan.vcxproj src/Vulkan/vulkan.vcxproj +1 -1

No files found.
--- a/src/Vulkan/vulkan.vcxproj
+++ b/src/Vulkan/vulkan.vcxproj
@@ -83,7 +83,7 @@ copy "$(OutDir)vk_swiftshader.dll" "$(SolutionDir)out\$(Configuration)_$(Platfor
      <Optimization>Disabled</Optimization>
      <SDLCheck>true</SDLCheck>
      <AdditionalIncludeDirectories>$(SolutionDir)include;$(SolutionDir)src;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;DEBUGGER_WAIT_DIALOG;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>_DEBUG;_WINDOWS;_USRDLL;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;%(PreprocessorDefinitions)</PreprocessorDefinitions>
      <RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
      <AdditionalOptions>/permissive- %(AdditionalOptions)</AdditionalOptions>
      <TreatSpecificWarningsAsErrors>4018;5038;4838</TreatSpecificWarningsAsErrors>