Skip to content

S
swiftshader
Commit b5bfa503 by Ben Clayton
Options

SpirvShader: Implement OpBitFieldInsert

Bug: b/126873455 Tests: dEQP-VK.glsl.builtin.function.integer.bitfieldinsert.* Change-Id: I47baf70460ca9a2c829b4c83d517a813f315f539 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/28529Reviewed-by: 's avatarChris Forbes <chrisforbes@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Tested-by: 's avatarBen Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com>
parent d86db954
Showing with 13 additions and 0 deletions
src/Pipeline/SpirvShader.cpp
...@@ -379,6 +379,7 @@ namespace sw ...@@ -379,6 +379,7 @@ namespace sw
case spv::OpVectorExtractDynamic: case spv::OpVectorExtractDynamic:
case spv::OpVectorInsertDynamic: case spv::OpVectorInsertDynamic:
case spv::OpNot: // Unary ops case spv::OpNot: // Unary ops
case spv::OpBitFieldInsert:
case spv::OpBitFieldSExtract: case spv::OpBitFieldSExtract:
case spv::OpBitFieldUExtract: case spv::OpBitFieldUExtract:
case spv::OpBitReverse: case spv::OpBitReverse:
...@@ -1649,6 +1650,7 @@ namespace sw ...@@ -1649,6 +1650,7 @@ namespace sw
return EmitTranspose(insn, state); return EmitTranspose(insn, state);
case spv::OpNot: case spv::OpNot:
case spv::OpBitFieldInsert:
case spv::OpBitFieldSExtract: case spv::OpBitFieldSExtract:
case spv::OpBitFieldUExtract: case spv::OpBitFieldUExtract:
case spv::OpBitReverse: case spv::OpBitReverse:
...@@ -2352,6 +2354,17 @@ namespace sw ...@@ -2352,6 +2354,17 @@ namespace sw
case spv::OpLogicalNot: // logical not == bitwise not due to all-bits boolean representation case spv::OpLogicalNot: // logical not == bitwise not due to all-bits boolean representation
dst.move(i, ~src.UInt(i)); dst.move(i, ~src.UInt(i));
break; break;
case spv::OpBitFieldInsert:
{
auto insert = GenericValue(this, routine, insn.word(4)).UInt(i);
auto offset = GenericValue(this, routine, insn.word(5)).UInt(0);
auto count = GenericValue(this, routine, insn.word(6)).UInt(0);
auto one = SIMD::UInt(1);
auto v = src.UInt(i);
auto mask = Bitmask32(offset + count) ^ Bitmask32(offset);
dst.move(i, (v & ~mask) | ((insert << offset) & mask));
break;
}
case spv::OpBitFieldSExtract: case spv::OpBitFieldSExtract:
case spv::OpBitFieldUExtract: case spv::OpBitFieldUExtract:
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment