Skip to content

S
swiftshader
Commit b61d9d76 by Ben Clayton
Options

Pipeline: Remove hack to disable spirv-opt when debugging

All 3 issues listed have now been fixed. It is safe to reenable this. Fixes: b/147726513 Change-Id: Ie76b77cc67f0ab74f45c73da1a998bce5dffd4fa Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/48728Tested-by: 's avatarBen Clayton <bclayton@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
parent 1075baee
Showing with 1 addition and 9 deletions
src/Vulkan/VkPipeline.cpp
...@@ -102,15 +102,7 @@ std::shared_ptr<sw::SpirvShader> createShader( ...@@ -102,15 +102,7 @@ std::shared_ptr<sw::SpirvShader> createShader(
// instructions. // instructions.
const bool optimize = !dbgctx; const bool optimize = !dbgctx;
// TODO(b/147726513): Do not preprocess the shader if we have a debugger auto code = preprocessSpirv(key.getInsns(), key.getSpecializationInfo(), optimize);
// context.
// This is a work-around for the SPIR-V tools incorrectly reporting errors
// when debug information is provided. This can be removed once the
// following SPIR-V tools bugs are fixed:
// https://github.com/KhronosGroup/SPIRV-Tools/issues/3102
// https://github.com/KhronosGroup/SPIRV-Tools/issues/3103
// https://github.com/KhronosGroup/SPIRV-Tools/issues/3118
auto code = dbgctx ? key.getInsns() : preprocessSpirv(key.getInsns(), key.getSpecializationInfo(), optimize);
ASSERT(code.size() > 0); ASSERT(code.size() > 0);
// If the pipeline has specialization constants, assume they're unique and // If the pipeline has specialization constants, assume they're unique and
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment