Fix missing comparison operators.

The types can differ for many opcodes where the right-hand side is a constant, and this assert isn't that useful, so just remove the opcode checks. Bug chromium:805881 Change-Id: Ibcbda5123aaeaaf5753732d7cad4b5a3b331e963 Reviewed-on: https://swiftshader-review.googlesource.com/16730Tested-by: Nicolas Capens <nicolascapens@google.com> Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Fix missing comparison operators.
b64e0ceb · Nicolas Capens · Nicolas Capens · 9b5aa709 · b64e0ceb
Commit b64e0ceb authored Jan 26, 2018 by Nicolas Capens Committed by Nicolas Capens Jan 26, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

SubzeroReactor.cpp src/Reactor/SubzeroReactor.cpp +1 -1

No files found.
--- a/src/Reactor/SubzeroReactor.cpp
+++ b/src/Reactor/SubzeroReactor.cpp
@@ -709,7 +709,7 @@ namespace sw

 	static Value *createArithmetic(Ice::InstArithmetic::OpKind op, Value *lhs, Value *rhs)
 	{
-		assert(lhs->getType() == rhs->getType() || (llvm::isa<Ice::Constant>(rhs) && (op == Ice::InstArithmetic::Shl || Ice::InstArithmetic::Lshr || Ice::InstArithmetic::Ashr)));
+		assert(lhs->getType() == rhs->getType() || llvm::isa<Ice::Constant>(rhs));

 		bool swapOperands = llvm::isa<Ice::Constant>(lhs) && isCommutative(op);