Avoid vector element insert type mismatch.

Subzero silently allows inserting a 32-bit integer into a vector with 16-bit elements. This generates a pinsrd instruction, which requires SSE4.1, even when specifying to only support SSE2. This change emits a pinsrw instruction instead, which is SSE2. Bug swiftshader:20 Change-Id: I37bd0ebb6d9cfdd2cdef4788e89e9672386c685e Reviewed-on: https://swiftshader-review.googlesource.com/8450Reviewed-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <capn@google.com> Tested-by: Nicolas Capens <capn@google.com>

Avoid vector element insert type mismatch.
bf22bbf2 · Nicolas Capens · 5e6ca097 · bf22bbf2
Commit bf22bbf2 authored Jan 13, 2017 by Nicolas Capens
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

SubzeroReactor.cpp src/Reactor/SubzeroReactor.cpp +2 -1

No files found.
--- a/src/Reactor/SubzeroReactor.cpp
+++ b/src/Reactor/SubzeroReactor.cpp
@@ -2935,7 +2935,8 @@ namespace sw
 	Short4::Short4(RValue<Int> cast)
 	{
 		Value *vector = loadValue();
-		Value *insert = Nucleus::createInsertElement(vector, cast.value, 0);
+		Value *element = Nucleus::createTrunc(cast.value, Short::getType());
+		Value *insert = Nucleus::createInsertElement(vector, element, 0);
 		Value *swizzle = Swizzle(RValue<Short4>(insert), 0x00).value;

 		storeValue(swizzle);