System/Synchronization.hpp: Remove unlock() call before notify_one()

In this particular case, I do not see the issue described in b/133135427 to ever happen here - however helgrind seems to find this questionable, and unless this is causing a noticable performance impact I think we should err on the side of caution. Bug: b/133135427 Change-Id: I1e5fa02ed28b6146f8a6044999f92b141e001e13 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31810Tested-by: Ben Clayton <bclayton@google.com> Reviewed-by: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

System/Synchronization.hpp: Remove unlock() call before notify_one()
c77a18aa · Ben Clayton · b54838a9 · c77a18aa
Commit c77a18aa authored May 21, 2019 by Ben Clayton
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 1 deletion

Synchronization.hpp src/System/Synchronization.hpp +0 -1

No files found.
--- a/src/System/Synchronization.hpp
+++ b/src/System/Synchronization.hpp
@@ -273,7 +273,6 @@ void Chan<T>::put(const T &item)
 {
 	std::unique_lock<std::mutex> lock(mutex);
 	queue.push(item);
-	lock.unlock();
 	added.notify_one();
 }