Remove explicit -msse2 flags (and some other minor things)

-msse2 is passed by default in //build's gn setup (even -mssse3 now: https://chromium-review.googlesource.com/c/chromium/src/+/2311044), so there's no need to pass this explicitly. Also remove some other things that are already set elsewhere. No intended behavior change. Bug: chromium:1220175 Change-Id: Id49540d17e21362e5f57156b47cf49a5534d89af Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/55610Reviewed-by: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>

Remove explicit -msse2 flags (and some other minor things)
c8b6ec00 · Nico Weber · swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com · b45ad7a3 · c8b6ec00 · c8b6ec00
Commit c8b6ec00 authored Jul 08, 2021 by Nico Weber Committed by swiftshader-scoped@luci-project-accounts.iam.gserviceaccount.com Jul 08, 2021
6 changed files
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -83,7 +83,6 @@ config("swiftshader_config") {
    } else if (current_cpu == "x86") {  # 32 bit version
      cflags += [
        "-m32",
-        "-msse2",
        "-mfpmath=sse",
        "-march=pentium4",
        "-mtune=generic",

--- a/src/Common/BUILD.gn
+++ b/src/Common/BUILD.gn
@@ -21,8 +21,6 @@ config("swiftshader_common_private_config") {
      "/wd4201",  # nameless struct/union
      "/wd5030",  # attribute is not recognized
    ]
-  } else if (current_cpu == "x86" || current_cpu == "x64") {
-    cflags = [ "-msse2" ]
  }
 }

--- a/src/Main/BUILD.gn
+++ b/src/Main/BUILD.gn
@@ -29,10 +29,6 @@ config("swiftshader_main_private_config") {
        "-Wno-sign-compare",
      ]
    }
-  } else if (current_cpu == "x86" || current_cpu == "x64") {
-    cflags = [ "-msse2" ]
-    defines =
-        [ "NO_SANITIZE_FUNCTION=__attribute__((no_sanitize(\"function\")))" ]
  }
 }

--- a/src/Reactor/BUILD.gn
+++ b/src/Reactor/BUILD.gn
@@ -26,14 +26,6 @@ config("swiftshader_llvm_reactor_private_config") {
    ]
  } else {
    cflags = [ "-Wno-unused-local-typedef" ]
-    defines = [
-      "__STDC_CONSTANT_MACROS",
-      "__STDC_LIMIT_MACROS",
-    ]
-    if (current_cpu == "x86" || current_cpu == "x64") {
-      cflags += [ "-msse2" ]
-    }
  }
 }

--- a/src/Renderer/BUILD.gn
+++ b/src/Renderer/BUILD.gn
@@ -23,10 +23,7 @@ config("swiftshader_renderer_private_config") {
      "/wd5030",  # attribute is not recognized
    ]
  } else if (current_cpu == "x86" || current_cpu == "x64") {
-    cflags = [
+    cflags = [ "-Wno-sign-compare" ]
-      "-msse2",
-      "-Wno-sign-compare",
-    ]
  }
 }

--- a/third_party/llvm-10.0/BUILD.gn
+++ b/third_party/llvm-10.0/BUILD.gn
@@ -70,9 +70,6 @@ config("swiftshader_llvm_private_config") {
      "-Wno-unused-result",
      "-Wno-unused-variable",
    ]
-    if (current_cpu == "x86" || current_cpu == "x64") {
-      cflags += [ "-msse2" ]
-    }
  }
  defines = [