Skip to content

S
swiftshader
Commit c92bee53 by Nicolas Capens Committed by Nicolas Capens
Options

Remove coverage asserts for tested code

These asserts were put in place to warn us if they got test coverage. They do since https://swiftshader-review.googlesource.com/38929. All seven are hit by the new test. Bug: b/145836207 Change-Id: I1aba531a1d005b48185d0b3ba72b923d2997a88e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39088 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com> Reviewed-by: 's avatarBen Clayton <bclayton@google.com> Reviewed-by: 's avatarDavid Turner <digit@google.com>
parent 31916f49
Showing with 0 additions and 14 deletions
third_party/subzero/src/IceTargetLoweringX86BaseImpl.h
...@@ -6521,8 +6521,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6521,8 +6521,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
_movp(T, Src0R); _movp(T, Src0R);
_punpckl(T, Src1RM); _punpckl(T, Src1RM);
} else if (Index0 == Index2 && Index1 == Index3) { } else if (Index0 == Index2 && Index1 == Index3) {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs( auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(
Src0, Index0, Src1, Index1); Src0, Index0, Src1, Index1);
T = lowerShuffleVector_AllFromSameSrc( T = lowerShuffleVector_AllFromSameSrc(
...@@ -6558,8 +6556,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6558,8 +6556,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
} }
break; break;
CASE_SRCS_IN(0, 1, 1, 1) : { CASE_SRCS_IN(0, 1, 1, 1) : {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index0, auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index0,
Src1, Index1); Src1, Index1);
T = lowerShuffleVector_TwoFromSameSrc( T = lowerShuffleVector_TwoFromSameSrc(
...@@ -6575,16 +6571,12 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6575,16 +6571,12 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
break; break;
CASE_SRCS_IN(1, 0, 0, 1) : { CASE_SRCS_IN(1, 0, 0, 1) : {
if (Index0 == Index3 && Index1 == Index2) { if (Index0 == Index3 && Index1 == Index2) {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs( auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(
Src1, Index0, Src0, Index1); Src1, Index0, Src0, Index1);
T = lowerShuffleVector_AllFromSameSrc( T = lowerShuffleVector_AllFromSameSrc(
Unified, UNIFIED_INDEX_0, UNIFIED_INDEX_1, UNIFIED_INDEX_1, Unified, UNIFIED_INDEX_0, UNIFIED_INDEX_1, UNIFIED_INDEX_1,
UNIFIED_INDEX_0); UNIFIED_INDEX_0);
} else { } else {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified0 = lowerShuffleVector_UnifyFromDifferentSrcs( auto *Unified0 = lowerShuffleVector_UnifyFromDifferentSrcs(
Src1, Index0, Src0, Index1); Src1, Index0, Src0, Index1);
auto *Unified1 = lowerShuffleVector_UnifyFromDifferentSrcs( auto *Unified1 = lowerShuffleVector_UnifyFromDifferentSrcs(
...@@ -6621,8 +6613,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6621,8 +6613,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
} }
break; break;
CASE_SRCS_IN(1, 0, 1, 1) : { CASE_SRCS_IN(1, 0, 1, 1) : {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src1, Index0, auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src1, Index0,
Src0, Index1); Src0, Index1);
T = lowerShuffleVector_TwoFromSameSrc( T = lowerShuffleVector_TwoFromSameSrc(
...@@ -6635,8 +6625,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6635,8 +6625,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
} }
break; break;
CASE_SRCS_IN(1, 1, 0, 1) : { CASE_SRCS_IN(1, 1, 0, 1) : {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index2, auto *Unified = lowerShuffleVector_UnifyFromDifferentSrcs(Src0, Index2,
Src1, Index3); Src1, Index3);
T = lowerShuffleVector_TwoFromSameSrc(Src1, Index0, Index1, Unified, T = lowerShuffleVector_TwoFromSameSrc(Src1, Index0, Index1, Unified,
...@@ -6651,8 +6639,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector( ...@@ -6651,8 +6639,6 @@ void TargetX86Base<TraitsType>::lowerShuffleVector(
} }
break; break;
CASE_SRCS_IN(1, 1, 1, 1) : { CASE_SRCS_IN(1, 1, 1, 1) : {
assert(false && "Following code is untested but likely correct; test "
"and remove assert.");
T = lowerShuffleVector_AllFromSameSrc(Src1, Index0, Index1, Index2, T = lowerShuffleVector_AllFromSameSrc(Src1, Index0, Index1, Index2,
Index3); Index3);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment