Skip to content

S
swiftshader
Commit cd09f8e9 by Nicolas Capens Committed by Nicolas Capens
Options

Produce MSVC error when virtual class misses virtual destructor

This is already a warning treated as an error by GCC/Clang: -Werror=delete-non-virtual-dtor Bug: b/130335507 Change-Id: I9d44f668168e2a77da8839017871e469f5d53bcb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44788Tested-by: 's avatarNicolas Capens <nicolascapens@google.com> Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
parent 08afdde7
Showing with 1 addition and 0 deletions
CMakeLists.txt
......@@ -356,6 +356,7 @@ if(MSVC)
# Treat specific warnings as errors
list(APPEND SWIFTSHADER_COMPILE_OPTIONS
"/we4265" # class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly
"/we4018" # 'expression' : signed/unsigned mismatch
"/we4471" # 'enumeration': a forward declaration of an unscoped enumeration must have an underlying type (int assumed)
"/we4838" # conversion from 'type_1' to 'type_2' requires a narrowing conversion
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment