Enable the -Wdeprecated-copy compiler warning

CMakeLists.txt

@@ -424,6 +424,7 @@ else()
         "-Wreorder"
         "-Wsign-compare"
         "-Wmissing-braces"
+        "-Wdeprecated-copy"  # implicit copy constructor for 'X' is deprecated because of user-declared copy assignment operator.
     )
 
     if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
@@ -449,7 +450,7 @@ else()
         endif()
     endif()
 
-    # Disable pedanitc warnings
+    # Disable pedantic warnings
     if(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
         list(APPEND SWIFTSHADER_COMPILE_OPTIONS
             "-Wno-ignored-attributes"   # ignoring attributes on template argument 'X'
@@ -470,7 +471,6 @@ else()
             "-Wno-undefined-var-template"         # instantiation of variable 'X' required here, but no definition is available
             "-Wno-extra-semi"                     # extra ';' after member function definition
             "-Wno-unused-parameter"               # unused parameter 'X'
-            "-Wno-deprecated-copy"                # implicit copy constructor for 'X' is deprecated because of user-declared copy assignment operator.
 
             # Silence errors caused by unknown warnings when building with older
             # versions of Clang. This demands checking that warnings added above

src/Device/BC_Decoder.cpp

@@ -325,12 +325,9 @@ union Color
 
 		RGBA &operator=(const RGBA &other)
 		{
-			if(this != &other)
-			{
-				this->r = other.r;
-				this->g = other.g;
-				this->b = other.b;
-			}
+			this->r = other.r;
+			this->g = other.g;
+			this->b = other.b;
 
 			return *this;
 		}
@@ -350,12 +347,15 @@ union Color
 	{
 	}
 
+	Color(const Color &other)
+	{
+		this->rgba = other.rgba;
+	}
+
 	Color &operator=(const Color &other)
 	{
-		if(this != &other)
-		{
-			this->rgba = other.rgba;
-		}
+		this->rgba = other.rgba;
+
 		return *this;
 	}
 

src/Renderer/Matrix.hpp

@@ -36,7 +36,7 @@ namespace sw
 		       float m41, float m42, float m43, float m44);
 		Matrix(const Vector &v1, const Vector &v2, const Vector &v3);   // Column vectors
 
-		Matrix &operator=(const Matrix &N);
+		Matrix &operator=(const Matrix &N) = default;
 
 		// Row major order
 		float m[4][4];
@@ -181,18 +181,6 @@ namespace sw
 		M(4, 1) = 0;    M(4, 2) = 0;    M(4, 3) = 0;    M(4, 4) = 1;
 	}
 
-	inline Matrix &Matrix::operator=(const Matrix &N)
-	{
-		Matrix &M = *this;
-
-		M(1, 1) = N(1, 1); M(1, 2) = N(1, 2); M(1, 3) = N(1, 3); M(1, 4) = N(1, 4);
-		M(2, 1) = N(2, 1); M(2, 2) = N(2, 2); M(2, 3) = N(2, 3); M(2, 4) = N(2, 4);
-		M(3, 1) = N(3, 1); M(3, 2) = N(3, 2); M(3, 3) = N(3, 3); M(3, 4) = N(3, 4);
-		M(4, 1) = N(4, 1); M(4, 2) = N(4, 2); M(4, 3) = N(4, 3); M(4, 4) = N(4, 4);
-
-		return M;
-	}
-
 	inline float *Matrix::operator[](int i)
 	{
 		return m[i];

src/System/Half.cpp

@@ -85,13 +85,6 @@ half::operator float() const
 	return (float &)fp32i;
 }
 
-half &half::operator=(half h)
-{
-	fp16i = h.fp16i;
-
-	return *this;
-}
-
 half &half::operator=(float f)
 {
 	*this = half(f);

src/System/Half.hpp

@@ -30,7 +30,6 @@ public:
 
 	operator float() const;
 
-	half &operator=(half h);
 	half &operator=(float f);
 
 private:

third_party/subzero/pnacl-llvm/include/llvm/Bitcode/NaCl/NaClBitstreamReader.h

@@ -426,13 +426,7 @@ private:
   class Block {
   public:
     Block() = delete;
-    Block &operator=(const Block &Rhs) {
-      GlobalAbbrevs = Rhs.GlobalAbbrevs;
-      NumGlobalAbbrevs = Rhs.NumGlobalAbbrevs;
-      LocalAbbrevs = Rhs.LocalAbbrevs;
-      CodeAbbrev = Rhs.CodeAbbrev;
-      return *this;
-    }
+    Block &operator=(const Block &Rhs) = default;
     Block(NaClBitstreamReader::BlockInfo *GlobalAbbrevs,
           NaClBitcodeSelectorAbbrev &CodeAbbrev)
         : GlobalAbbrevs(GlobalAbbrevs),