Enable filtering of YCbCr formats

This is widely supported by other Vulkan drivers, and there's no reason these formats should be different from other ones when it comes to linear filtering. Bug: b/147586576 Change-Id: I43c8e4a65ab001c85f6c3621487a634f302d21a1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40250Reviewed-by: Alexis Hétu <sugoi@google.com> Tested-by: Nicolas Capens <nicolascapens@google.com>

Enable filtering of YCbCr formats
d6d0edc2 · Nicolas Capens · Nicolas Capens · d95467ec · d6d0edc2
Commit d6d0edc2 authored Jan 15, 2020 by Nicolas Capens Committed by Nicolas Capens Jan 17, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

VkPhysicalDevice.cpp src/Vulkan/VkPhysicalDevice.cpp +5 -4

No files found.
--- a/src/Vulkan/VkPhysicalDevice.cpp
+++ b/src/Vulkan/VkPhysicalDevice.cpp
@@ -467,7 +467,7 @@ void PhysicalDevice::getFormatProperties(Format format, VkFormatProperties *pFor

 	switch(format)
 	{
-			// Formats which can be sampled *and* filtered
+		// Formats which can be sampled *and* filtered
 		case VK_FORMAT_B4G4R4A4_UNORM_PACK16:
 		case VK_FORMAT_R5G6B5_UNORM_PACK16:
 		case VK_FORMAT_A1R5G5B5_UNORM_PACK16:
@@ -522,9 +522,9 @@ void PhysicalDevice::getFormatProperties(Format format, VkFormatProperties *pFor
 		case VK_FORMAT_D32_SFLOAT_S8_UINT:
 			pFormatProperties->optimalTilingFeatures |=
 			    VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT;
-			// Fall through
+			// [[fallthrough]]

-			// Formats which can be sampled, but don't support filtering
+		// Formats which can be sampled, but don't support filtering
 		case VK_FORMAT_R8_UINT:
 		case VK_FORMAT_R8_SINT:
 		case VK_FORMAT_R8G8_UINT:
@@ -555,11 +555,12 @@ void PhysicalDevice::getFormatProperties(Format format, VkFormatProperties *pFor
 			    VK_FORMAT_FEATURE_TRANSFER_DST_BIT;
 			break;

-			// YCbCr formats:
+		// YCbCr formats:
 		case VK_FORMAT_G8_B8_R8_3PLANE_420_UNORM:
 		case VK_FORMAT_G8_B8R8_2PLANE_420_UNORM:
 			pFormatProperties->optimalTilingFeatures |=
 			    VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT |
+			    VK_FORMAT_FEATURE_SAMPLED_IMAGE_FILTER_LINEAR_BIT |
 			    VK_FORMAT_FEATURE_TRANSFER_SRC_BIT |
 			    VK_FORMAT_FEATURE_TRANSFER_DST_BIT |
 			    VK_FORMAT_FEATURE_COSITED_CHROMA_SAMPLES_BIT;